Fix crash due to static variable initialization order #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static variable `equal_string_ordinal_ic` is not yet initialized when
invoking `boost::filesystem::remove_all(dir)` also at static initialization
time.
Real example code that causes the issue (global scope):
```
/// \hack
/// Forces 1 time shared memory cleanup on filesystem.
static class cleanup_shared_memory
{
public:
cleanup_shared_memory()
{
try
{
std::string dir;
ipcdetail::get_shared_dir_root(dir);
boost::filesystem::remove_all(dir);
LOG_INFO << "Removed old shared memory data: " << dir;
}
catch (boost::filesystem::filesystem_error const& e)
{
LOG_ERROR << "Could not remove old shared memory data: " << e.what();
}
}
} do_not_remove;
```
Lastique
reviewed
Aug 8, 2017
|
|
||
| perms make_permissions(const path& p, DWORD attr) | ||
| { | ||
| static Ptr_equal_string_ordinal_ic equal_string_ordinal_ic = |
There was a problem hiding this comment.
Function-local statics are not thread-safe in C++03.
There was a problem hiding this comment.
Statics aren't thread safe period. I expect to see some synchronization happening here if this needs to be thread safe. I don't see how my change affects the threading aspect of the code, since a global isn't thread safe either.
|
Closing in favor of #43 (mine is a duplicate of that and more discussion has happened there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static variable
equal_string_ordinal_icis not yet initialized wheninvoking
boost::filesystem::remove_all(dir)also at static initializationtime.
Real example code that causes the issue (global scope):