Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't use readdir_r on Linux and Android #68
referenced this pull request
Apr 10, 2018
Apart from avoiding to use the deprecated functionality, this patch fixes issue #72. I.e. the patch is useful not only for GNU/Linux, but also for Android/Linux.
Android NDK developers recommend to use
About thread-safety of
Non-maintainer review of the patch. Hopefully will help the maintainers to spend less time on their official review.
The patch is tiny, straightforward, very understandable.
The patch adds conditions checking for
The patch can benefit from comment(s), explaining why a condition was added.
Even if the patch can be improved, I think it is already good and can be merged in.
I just ran into this while building with "warnings as errors" in iostreams:
Any reason why this hasn't been merged?