Symmetrizing read/write wkt #670

sudo-panda · 2020-02-29T12:51:58Z

This PR fixes #654 . It adds the following:

to_wkt: This function converts the given geometry to wkt string and returns it instead of modifying a stringstream taken as input like wkt.
from_wkt: This function returns the geometry obtained by parsing a wkt string instead of taking in a geometry variable as parameter and storing the geometry in it.
tests: Tests for both to_wkt and from_wkt are provided with basically follow the template of already implemented read_wkt and wkt tests.
examples and documentation: Example usage of both have been added and documentation has been updated.

This PR is now ready to be reviewed and then merged.

mloskot

Although needs some changes, it's looking good.

Please, consider also

new example in oc/src/examples/io/
finding if there is place for documentation (look for .qbk files for other wkt functions)

include/boost/geometry/io/wkt/write.hpp

test/io/wkt/wkt.cpp

mloskot

This is getting complete. I just pointed out a bunch of issues.

doc/html/index.html

doc/src/examples/io/from_wkt.cpp

doc/reference/io/read_wkt.qbk

vissarion

Looks OK to me. Thanks!

include/boost/geometry/io/wkt/write.hpp

mloskot · 2020-03-05T11:06:18Z

@sudo-panda FYI, next time you update your PR, then documentation and doc/src/examples will be built and verified with GitHub Actions.

mloskot

@sudo-panda Thanks for another round of your efforts. This to me is looking good, just having two minor requests.

include/boost/geometry/io/wkt/write.hpp

mloskot · 2020-03-09T23:42:56Z

@sudo-panda If you update your PR, you will get #680 change and GitHub Actions will CI check it for you.

mloskot

This looks good to me and ready to merge.
If no objections arrive from @awulkiew or @vissarion in next days, I'll merge it.

I assume @barendgehrels generally agrees on such utility functions as per his #654 (comment) and #654 (comment)

@sudo-panda Thanks for your work!

sudo-panda · 2020-03-14T22:25:58Z

@mloskot thanks for the guidance and approving the PR.

vissarion

Thanks I am ok with merging.

test/io/wkt/wkt.cpp

include/boost/geometry/io/wkt/write.hpp

- Add example demonstrating use of `significant_digits` in `to_wkt` - Add example demonstrating use of `significant_digits` in `wkt` - Add parameter documentation

- Add test for `to_wkt` and `wkt`

- Check if significant digit `<0` instead of `==-1` - Check if type is arithmetic in append function

- Set precision to `digits10` when `T` is specialized and the user doesn't specify the precision - Set precision to the user supplied precision in all other cases

- Overload function w.r.t. `significant_digits` parameter

- to_wkt() now internally calls wkt() - minor change: added copyright to read.hpp

Using alias-declaration instead of typedef

vissarion

I am also OK with merging most of this PR but (as @barendgehrels ) I do not understand exactly what to_wkt adds on top of the stream operator.

awulkiew · 2020-12-07T13:38:37Z

@barendgehrels @vissarion This PR implements this issue: #654

vissarion · 2020-12-10T15:00:47Z

@barendgehrels @vissarion This PR implements this issue: #654

Right, thanks! So it seems there is user need so I will not go against. I am OK with this PR.

mloskot · 2020-12-10T16:11:01Z

@vissarion, @barendgehrels

Right, thanks! So it seems there is user need so I will not go against. I am OK with this PR.

Yes, there seem to be a need indeed.

Although the lengthy discussion we've had on this PR may given an impression it's a big feature, it is not.
It just a little thing that smoothens up a particular rough edge of the WKT I/O interface making it just a bit more expressive and fluent. Apparently, for users, every little helps :-)

barendgehrels · 2020-12-11T18:13:02Z

@vissarion, @barendgehrels

Right, thanks! So it seems there is user need so I will not go against. I am OK with this PR.

Yes, there seem to be a need indeed.

Although the lengthy discussion we've had on this PR may given an impression it's a big feature, it is not.
It just a little thing that smoothens up a particular rough edge of the WKT I/O interface making it just a bit more expressive and fluent. Apparently, for users, every little helps :-)

Thanks for the link (I mean the one with issue #654) . Yes, I remember now and I was OK back then, so I'm still OK now. I will approve.

awulkiew · 2021-03-03T13:05:30Z

I apologize it took so long. Thanks for this PR!

mloskot added the enhancement label Feb 29, 2020

mloskot requested changes Feb 29, 2020

View reviewed changes

sudo-panda requested review from mloskot and awulkiew March 2, 2020 20:15

sudo-panda changed the title ~~[WIP] Symmetrizing read/write wkt~~ Symmetrizing read/write wkt Mar 2, 2020

mloskot requested changes Mar 2, 2020

View reviewed changes

doc/html/index.html Show resolved Hide resolved

doc/src/examples/io/from_wkt.cpp Outdated Show resolved Hide resolved

doc/reference/io/read_wkt.qbk Show resolved Hide resolved

sudo-panda requested a review from mloskot March 3, 2020 08:48

vissarion self-requested a review March 3, 2020 13:55

vissarion approved these changes Mar 3, 2020

View reviewed changes

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 3, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

vissarion reviewed Mar 4, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

vissarion self-requested a review March 4, 2020 11:24

awulkiew reviewed Mar 4, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

mloskot requested changes Mar 7, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

sudo-panda requested review from mloskot and awulkiew March 8, 2020 09:58

sudo-panda mentioned this pull request Mar 14, 2020

Writing 3D WKT: Z in prefix? #664

Open

mloskot approved these changes Mar 14, 2020

View reviewed changes

vissarion reviewed Mar 17, 2020

View reviewed changes

test/io/wkt/wkt.cpp Show resolved Hide resolved

awulkiew reviewed Mar 17, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 17, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

awulkiew reviewed Mar 17, 2020

View reviewed changes

include/boost/geometry/io/wkt/write.hpp Outdated Show resolved Hide resolved

sudo-panda added 18 commits December 3, 2020 17:07

[ex][io][wkt] add significant_digits example

cfd58ad

- Add example demonstrating use of `significant_digits` in `to_wkt` - Add example demonstrating use of `significant_digits` in `wkt` - Add parameter documentation

[io][wkt] add ostream template specialization of output_formatter

1fd9b22

[doc][io][wkt] minor changes and bug fixes

44c342c

[test][io][wkt] add test for significant_digits

72a4788

- Add test for `to_wkt` and `wkt`

[io][wkt] minor changes

2051e75

- Check if significant digit `<0` instead of `==-1` - Check if type is arithmetic in append function

[test][io][wkt] add debug messages

5abaed5

[io][wkt] modify conditions for setting precision

fa4b3dd

- Set precision to `digits10` when `T` is specialized and the user doesn't specify the precision - Set precision to the user supplied precision in all other cases

[io][wkt] remove specialization for ostream

36cf42f

[io][wkt] remove significant_digits from wkt

89c58a6

[io][wkt] overload to_wkt function

322cd9f

- Overload function w.r.t. `significant_digits` parameter

[doc][io] remove set precision example in wkt

6bf00d4

[test][io][wkt] remove test for precise wkt

6b67192

[io][wkt] fix formatting

2d096e5

[io][wkt] fix if formatting

d4e9f6e

[doc] add copyright information

3b08f8c

[io][wkt] Revert changes and make to_wkt a wrapper

ea31a91

- to_wkt() now internally calls wkt() - minor change: added copyright to read.hpp

[ex][io][wkt] mordernize the example

1d32d87

Using alias-declaration instead of typedef

[ex][io][wkt] modify ex to show adv of from_wkt

0839e31

sudo-panda force-pushed the feature/symmetric-wkt branch from cc31ea9 to 0839e31 Compare December 3, 2020 11:39

vissarion self-requested a review December 7, 2020 11:19

vissarion reviewed Dec 7, 2020

View reviewed changes

barendgehrels approved these changes Dec 11, 2020

View reviewed changes

awulkiew approved these changes Mar 3, 2021

View reviewed changes

awulkiew added this to the 1.76 milestone Mar 3, 2021

awulkiew merged commit 28559c0 into boostorg:develop Mar 3, 2021

Symmetrizing read/write wkt #670

Symmetrizing read/write wkt #670

Uh oh!

Conversation

sudo-panda commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mloskot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mloskot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vissarion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mloskot commented Mar 5, 2020

Uh oh!

mloskot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mloskot commented Mar 9, 2020

Uh oh!

mloskot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudo-panda commented Mar 14, 2020

Uh oh!

vissarion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vissarion left a comment

Choose a reason for hiding this comment

Uh oh!

awulkiew commented Dec 7, 2020

Uh oh!

vissarion commented Dec 10, 2020

Uh oh!

mloskot commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barendgehrels commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

awulkiew commented Mar 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sudo-panda commented Feb 29, 2020 •

edited

Loading

mloskot left a comment •

edited

Loading

mloskot commented Dec 10, 2020 •

edited

Loading

barendgehrels commented Dec 11, 2020 •

edited

Loading

awulkiew commented Mar 3, 2021 •

edited

Loading