Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed most of warnings in examples and some in core library #545

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

Scramjet911
Copy link
Contributor

@Scramjet911 Scramjet911 commented Jan 25, 2021

Description

This PR fixes multiple warnings showing up during boost build process. Including the fixes of the examples, and some other warnings from core header files.

References

#436

const BitField channel_mask = static_cast< integer_t >( parent_t::max_val ) << _first_bit;

Fixing this warning causes a test to fail and I couldn't figure out why that was happening, so I skipped fixing that one for now.

Tasklist

  • Fix other warnings
  • Check if all these fixes cause other issues.
  • Ensure all CI builds pass
  • Review and approve

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this PR to get the latest changes from the develop branch?

@Scramjet911
Copy link
Contributor Author

Could you update this PR to get the latest changes from the develop branch?

@mloskot Yes, I have done that now, rebased my branch on current develop.

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I suggested a few improvements

example/hessian.cpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
@mloskot mloskot added the cat/annoyance Not a bug, not a feature, but something that should be improved label Jan 28, 2021
mloskot added a commit that referenced this pull request Jan 28, 2021
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloskot mloskot merged commit 90f7952 into boostorg:develop Feb 2, 2021
@mloskot mloskot changed the title Fixed most of the warnings in the examples and many of the boost build process Fixed most of warnings in examples and some in core library Feb 2, 2021
meshtag pushed a commit to meshtag/gil that referenced this pull request Mar 17, 2021
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 21, 2021
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 22, 2021
sdebionne pushed a commit to sdebionne/gil-reformated that referenced this pull request May 26, 2021
sdebionne pushed a commit to sdebionne/gil-reformated that referenced this pull request Jun 23, 2021
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/annoyance Not a bug, not a feature, but something that should be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants