Skip to content

Fix/mingw #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2014
Merged

Fix/mingw #3

merged 2 commits into from
May 25, 2014

Conversation

awulkiew
Copy link
Member

No description provided.

awulkiew added 2 commits May 25, 2014 17:13
@awulkiew
Fix interprocess_exception throw in file_wrapper::priv_open_or_create.
f1e1af0 
On Windows the exception object is created using the result of GetLastError().
When compiled using MinGW the throw instruction itself is using some WinApi call which overwrites the last error.
Therefore the error code must be retrieved before the exception is thrown.
@awulkiew
Rephrase the #ifdef in errors.hpp
d0a647b
@igaztanaga
Copy link
Member

Thanks for the report. Information on strange interactions between GetLastError and exceptions:

http://stackoverflow.com/questions/8671483/why-does-getlasterror-return-0-or-2-depending-on-how-it-is-called

@igaztanaga igaztanaga merged commit d0a647b into boostorg:develop May 25, 2014
@awulkiew awulkiew deleted the fix/mingw branch May 26, 2014 19:01
@mtg49 mtg49 mentioned this pull request Feb 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awulkiew @igaztanaga