Skip to content

Conversation

joaquintides
Copy link
Member

Added support for Drone CI. Some notes:

  • Compilers tested include GCC 8 to 9 and Clang 7 to 11, which are not part of GHA CI (.github/workflows/ci.yml). Even though tests pass for all of them, you may want to remove some if you're not commiting to supporting them.
  • MSVC 14.2 and 14.3 with /std:c++17 do not pass the following tests:
compile_fail_bad_virtual_parameter
compile_fail_virtual_ptr_different_registries

that is, they compile without errors when they shouldn't. GHA CI does not have this problem for MSVC 14.2, but it does for MSVC 14.3. I don't know the reason for the discrepancy with MSVC 14.2. I left this as is pending your eventual investigation.

@joaquintides joaquintides requested a review from jll63 as a code owner September 16, 2025 16:26
@joaquintides joaquintides requested review from jll63 and removed request for jll63 September 16, 2025 16:28
Copy link
Collaborator

@jll63 jll63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We understand the reasons for CI failures and we are not production yet, so I'll approve and work on this later.

@jll63 jll63 merged commit 34ebad0 into develop Sep 16, 2025
52 of 64 checks passed
@joaquintides joaquintides deleted the feature/drone-ci branch September 17, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants