Fix auto-pointer registration in Boost Python 1.60. #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional instantiation magic of maybe_register_pointer_to_python() assumes that use_value_holder and use_back_reference will be one of the boost::mpl::bool_ types, but this assumption is no longer true in Boost 1.60, where they can be standard library bool wrappers instead. Explicitly defining these types as mpl::bool_ classes fixes boostorg#56.
|
Thanks for the patch. I verified that this works locally, so let's merge this. |
stefanseefeld
added a commit
that referenced
this pull request
Mar 6, 2016
Fix auto-pointer registration in Boost Python 1.60.
This was referenced Apr 20, 2016
UniqMartin
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 22, 2016
Add a patch that backports an upstream commit to fix a bug in 1.60. Patch derived from boostorg/python@e9c265a Pull request boostorg/python#59 Closes #516. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
ptosco
added a commit
to ptosco/MINGW-packages
that referenced
this pull request
Aug 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional instantiation magic of maybe_register_pointer_to_python() assumes that use_value_holder and use_back_reference will be one of the boost::mpl::bool_ types, but this assumption is no longer true in Boost 1.60, where they can be standard library bool wrappers instead.
Explicitly defining these types as mpl::bool_ classes fixes #56.