Skip to content

Conversation

anarthal
Copy link
Collaborator

Implements redis_stream::async_connect as a FSM
Adds per-operation cancellation handling code
Adds tests

@anarthal
Copy link
Collaborator Author

This is an early prototype yet. I've started implementing #319 and it was getting too big and messy around redis_stream::async_connect. This implements the required code to handle per-operation cancellation correctly in async_connect, while covering this code with tests.

@anarthal anarthal marked this pull request as ready for review October 3, 2025 18:10
@anarthal
Copy link
Collaborator Author

anarthal commented Oct 3, 2025

This should fix the last race conditions on cancellation and add some coverage.

@mzimbres
Copy link
Collaborator

mzimbres commented Oct 3, 2025

Hi Ruben, thanks. This is something I forgot to ask you before: can you please rebase on top of develop before opening a PR and merging? This results in simpler history and it is easier for me to review the PR locally. I think it will be too complex for this PR so we can do this for the next PRs.

@anarthal
Copy link
Collaborator Author

anarthal commented Oct 3, 2025

I think this one is actually good - it's just ultra segmented in terms of commits, but they're all part of the PR. I always do squash merging when merging, so these won't appear in history - just a big commit replacing them.

I did something wrong in the cancel_after PR which I think I've solved now.

@anarthal
Copy link
Collaborator Author

anarthal commented Oct 3, 2025

(looks like I commited once per test and wrote about 20 tests, so... :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants