Made the mem_cache_block lockfree #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This *significantly* improves parallel performance of regex. Currently if I have a large number of threads all using regexes; even if they are using idependent regex objects, performance is still extremely poor due to the lock inside of the mem_block_cache.
|
This is a good idea, but the patch isn't completely portable just yet. For preference I would like a solution which:
|
|
sounds good. I will update the pull request. |
|
I have updated with the suggested checks. |
| @@ -19,17 +19,72 @@ | |||
| #define BOOST_REGEX_V4_MEM_BLOCK_CACHE_HPP | |||
|
|
|||
| #include <new> | |||
| #ifdef BOOST_HAS_THREADS | |||
There was a problem hiding this comment.
This include is still needed when neither not <boost/atomic.hpp> provide the functionality we require.
|
Sorry for the delay. I have updated the pull request with the fixes. |
I'm also backlogged, will get to this shortly, John. |
|
Many thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves parallel performance of regex.
Currently if I have a large number of threads all using regexes; even if
they are using idependent regex objects, performance is still extremely poor
due to the lock inside of the mem_block_cache.