End WinDbg session to prevent memory from leaking #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihm-tswow
added a commit
to ihm-tswow/bxx
that referenced
this pull request
Sep 11, 2022
- fix from here: boostorg/stacktrace#124 - thanks to https://github.com/akarpovskii for posting pdb unload fix!
|
@akarpovskii , it looks like path breaks something. See #130 the CI failures The MSVC STL implementation also does not do the EndSession https://github.com/microsoft/STL/blob/main/stl/src/stacktrace.cpp |
|
@apolukhin, sorry for leaving the PR unfinished. At the time I didn't have enough expertise to figure this out, and now I don't have access to a Windows machine to finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If BOOST_STACKTRACE_USE_WINDBG is defined, the implementation of
stacktrace::to_stringopens a new WinDbg session each time without ending the previous one which results in leaking memory (see #111).This PR adds the missing EndSession call in the
debugging_symbolsdestructor.