Skip to content

Fix build with MinGW-w64 12+. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2023
Merged

Fix build with MinGW-w64 12+. #140

merged 2 commits into from
Sep 2, 2023

Conversation

yh-sb
Copy link
Contributor

@yh-sb yh-sb commented Aug 21, 2023

For more details see: #133.

Fixes the following errors with MinGW-w64 12 or higher:

D:/dev/third_party/boost/libs/stacktrace/include/boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of 'struct __mingw_uuidof_s<IDebugClient>'
   31 |     __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      |     ^~~~~~~~~~~~~~~
C:/Program Files/mydevtools/MinGW-w64/x86_64-w64-mingw32/include/dbgeng.h:262:1: note: previous definition of 'struct __mingw_uuidof_s<IDebugClient>'
  262 | __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      | ^~~~~~~~~~~~~~~
D:/dev/third_party/boost/libs/stacktrace/include/boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of 'constexpr const GUID& __mingw_uuidof() [with T = IDebugClient; GUID = GUID]'
   31 |     __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      |     ^~~~~~~~~~~~~~~
C:/Program Files/mydevtools/MinGW-w64/x86_64-w64-mingw32/include/dbgeng.h:262:1: note: 'constexpr const GUID& __mingw_uuidof() [with T = IDebugClient; GUID = GUID]' previously declared here
  262 | __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      | ^~~~~~~~~~~~~~~
D:/dev/third_party/boost/libs/stacktrace/include/boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of 'constexpr const GUID& __mingw_uuidof() [with T = IDebugClient*; GUID = GUID]'
   31 |     __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      |     ^~~~~~~~~~~~~~~
C:/Program Files/mydevtools/MinGW-w64/x86_64-w64-mingw32/include/dbgeng.h:262:1: note: 'constexpr const GUID& __mingw_uuidof() [with T = IDebugClient*; GUID = GUID]' previously declared here
  262 | __CRT_UUID_DECL(IDebugClient,0x27fe5639,0x8407,0x4f47,0x83,0x64,0xee,0x11,0x8f,0xb0,0x8a,0xc8)
      | ^~~~~~~~~~~~~~~
D:/dev/third_party/boost/libs/stacktrace/include/boost/stacktrace/detail/frame_msvc.ipp:32:5: error: redefinition of 'struct __mingw_uuidof_s<IDebugControl>'
   32 |     __CRT_UUID_DECL(IDebugControl,0x5182e668,0x105e,0x416e,0xad,0x92,0x24,0xef,0x80,0x04,0x24,0xba)
      |     ^~~~~~~~~~~~~~~
C:/Program Files/mydevtools/MinGW-w64/x86_64-w64-mingw32/include/dbgeng.h:818:1: note: previous definition of 'struct __mingw_uuidof_s<IDebugControl>'
  818 | __CRT_UUID_DECL(IDebugControl,0x5182e668,0x105e,0x416e,0xad,0x92,0x24,0xef,0x80,0x04,0x24,0xba)
      | ^~~~~~~~~~~~~~~
D:/dev/third_party/boost/libs/stacktrace/include/boost/stacktrace/detail/frame_msvc.ipp:32:5: error: redefinition of 'constexpr const GUID& __mingw_uuidof() [with T = IDebugControl; GUID = GUID]'
   32 |     __CRT_UUID_DECL(IDebugControl,0x5182e668,0x105e,0x416e,0xad,0x92,0x24,0xef,0x80,0x04,0x24,0xba)
      |     ^~~~~~~~~~~~~~~
C:/Program Files/mydevtools/MinGW-w64/x86_64-w64-mingw32/include/dbgeng.h:818:1: note: 'constexpr const GUID& __mingw_uuidof() [with T = IDebugControl; GUID = GUID]' previously declared here
  818 | __CRT_UUID_DECL(IDebugControl,0x5182e668,0x105e,0x416e,0xad,0x92,0x24,0xef,0x80,0x04,0x24,0xba)
      | ^~~~~~~~~~~~~~~
...

Fix build with MinGW-w64 12+.
b184889 
For more details see: #133
@yh-sb yh-sb mentioned this pull request Aug 21, 2023
Closed
petrutlucian94
petrutlucian94 reviewed Aug 22, 2023
View reviewed changes
Accommodate mingw-llvm to this fix as well
b12e3be 
macros defined by mingw-llvm 16 (https://github.com/mstorsjo/llvm-mingw):
#define __GNUC_MINOR__ 2
#define __GNUC_PATCHLEVEL__ 1
#define __GNUC__ 4

#define __clang_major__ 16
#define __clang_minor__ 0
#define __clang_patchlevel__ 0
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
69c3174 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
0eff013 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
2f42f72 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
0c7ec54 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
7068e1b 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 24, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
d2ffe62 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Aug 25, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
98660fd 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
@idryomov idryomov mentioned this pull request Aug 30, 2023
Merged
14 tasks
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 30, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
7a43237 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to petrutlucian94/ceph that referenced this pull request Aug 30, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
157ec51 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Aug 31, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
d592d25 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Sep 1, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
9dc65fc 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
@apolukhin apolukhin merged commit dc5cd9d into boostorg:develop Sep 2, 2023
@apolukhin
Copy link
Member

Many thanks for the PR!

benhanokh pushed a commit to benhanokh/ceph that referenced this pull request Sep 10, 2023
@petrutlucian94 @benhanokh
win32_deps_build.sh: avoid duplicate boost definitions
5c0d731 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Sep 25, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
0644caf 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
vedanshbhartia pushed a commit to vedanshbhartia/ceph that referenced this pull request Oct 9, 2023
@petrutlucian94 @vedanshbhartia
win32_deps_build.sh: avoid duplicate boost definitions
46d07be 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Oct 11, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
2ea6ef8 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Nov 7, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
3857803 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94 added a commit to cloudbase/ceph that referenced this pull request Nov 22, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
6d3911e 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Dec 6, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
580bb39 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Dec 26, 2023
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
5c7d5a7 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Jan 2, 2024
@petrutlucian94
win32_deps_build.sh: avoid duplicate boost definitions
988afc2 
Boost stacktrace defines a few UUIDs that were recently added
to mingw as well [1], causing compilation errors [2]:

  In file included from libs/stacktrace/build/../src/windbg.cpp:9:
  ./boost/stacktrace/detail/frame_msvc.ipp:31:5: error: redefinition of
    '__mingw_uuidof_s<IDebugClient>'
    __CRT_UUID_DECL(IDebugClient,0x27fe5639,...

We'll apply a fix that hasn't merged upsteam yet [3].

[1] mirror/mingw-w64@ce5a9f6
[2] boostorg/stacktrace#133
[3] boostorg/stacktrace#140

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
mabrarov added a commit to mabrarov/build-scripts that referenced this pull request Apr 13, 2025
@mabrarov
Patch for Boost.Stacktrace in Boost 1.83.0 (boostorg/stacktrace#140).
f947521
@mabrarov mabrarov mentioned this pull request Apr 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@petrutlucian94 petrutlucian94 petrutlucian94 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yh-sb @apolukhin @petrutlucian94