New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning: BOOST_CLANG is not defined, evaluates to 0 #151

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@mloskot
Member

mloskot commented Aug 24, 2018

The diagnostic is issued when compiled with GCC/clang flag -Wundef.

Although in case BOOST_CLANG is not defined, ie. is not a macro and BOOST_CLANG identifier is considered to be zero, the #ifdef directive makes the intention clearer.

Fix warning: BOOST_CLANG is not defined, evaluates to 0
The diagnostic is issued when compiled with GCC/clang flag -Wundef.

Although in case BOOST_CLANG is not defined, ie. is not a macro
and BOOST_CLANG identifier is considered to be zero, the #ifdef
directive makes the intention clearer.
@raffienficiaud

This comment has been minimized.

Member

raffienficiaud commented Sep 2, 2018

Wouldn't

#if defined(BOOST_CLANG) && (BOOST_CLANG == 1)

be safer? I updated the branch topic/PR-151-BOOST_CLANG-define accordingly.

@mloskot

This comment has been minimized.

Member

mloskot commented Sep 2, 2018

Or, BOOST_CLANG != 0. Sure, why not.

@raffienficiaud

This comment has been minimized.

Member

raffienficiaud commented Sep 3, 2018

Merged to next.

@raffienficiaud

This comment has been minimized.

Member

raffienficiaud commented Sep 3, 2018

Thanks, merged to develop

@mloskot

This comment has been minimized.

Member

mloskot commented Sep 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment