Fix warning: BOOST_CLANG is not defined, evaluates to 0 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagnostic is issued when compiled with GCC/clang flag -Wundef. Although in case BOOST_CLANG is not defined, ie. is not a macro and BOOST_CLANG identifier is considered to be zero, the #ifdef directive makes the intention clearer.
|
Wouldn't be safer? I updated the branch |
|
Or, |
|
Merged to next. |
|
Thanks, merged to develop |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic is issued when compiled with GCC/clang flag
-Wundef.Although in case
BOOST_CLANGis not defined, ie. is not a macro andBOOST_CLANGidentifier is considered to be zero, the#ifdefdirective makes the intention clearer.