Skip to content

Cleanup #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

austin-beer
Copy link
Contributor

These are a series of commits that been sitting in my local workspace for a couple of weeks now. I was going to wait until after I'd finished the win32 changes before submitting them, but I decided to go ahead and submit them now to get them out of the way.

See the commit log for the list of changes I made.

@viboes
Copy link
Collaborator

viboes commented Oct 26, 2017

Great we start to see green run in windows :)

@austin-beer
Copy link
Contributor Author

A few green runs, at least. :)

@austin-beer
Copy link
Contributor Author

FYI, the 64-bit Windows builds are failing due the unit tests exceeding the 260 character filepath limit on Windows. Every filepath includes \msvc-14.1\debug\address-model-64\threadapi-win32\threading-multi. Do you know if there is an easy way to shorten this? On the 32-bit builds the filepaths don't have \address-model-64 which is just enough to keep them under the 260 character limit so they don't fail.

@viboes
Copy link
Collaborator

viboes commented Oct 27, 2017

Thanks for the info. /threadapi-win32 was added in order to do cross compiling.

No I don't know how to shorten them.

Could you create a issue for Boost.Build with the specific compiler report?

@viboes
Copy link
Collaborator

viboes commented Oct 27, 2017

Steven Watanabe said on Boost ML
"
--abbreviate-paths

http://www.boost.org/build/doc/html/bbv2/reference/buildprocess.html#bbv2.reference.buildprocess.targetpath
"

@viboes
Copy link
Collaborator

viboes commented Oct 27, 2017

I've added --abbreviate-paths

@viboes viboes merged commit d19a249 into boostorg:feature/timespec_clocks Oct 27, 2017
@austin-beer
Copy link
Contributor Author

--abbreviate-paths sounds like the solution we need. Thanks for adding that.

@austin-beer austin-beer deleted the feature/timespec_clocks_pr20_cleanup branch October 27, 2017 15:15
@austin-beer
Copy link
Contributor Author

Glad to help. Which AppVeyor build are you looking at that's all green?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants