Improve algorithm implementation for compiler optimization, closes #150 #155
Conversation
Neel-Shah-29
changed the title
|
Follow https://www.conventionalcommits.org/en/v1.0.0/ for a commit message, and be more explicit about the message rather than generic. |
Yes sure I will do it. Also issue is resolved right as all checks are passed so i dont need to make any further changes right? |
Neel-Shah-29
changed the title
|
I have made the required changes. |
bassoy
changed the title
We should fix them now if we have any. @amitsingh19975 Please annotate the lines which you think need better indentation.
|
| std::function<ValueType(SizeType r, PointerIn a, ValueType k)> lambda; | ||
|
|
||
| lambda = [&lambda, n, w](SizeType r, PointerIn a, ValueType k) | ||
| auto lambda = [n, w](auto const& self, SizeType r, PointerIn a, ValueType k)-> ValueType |
There was a problem hiding this comment.
Done with the changes
bassoy
changed the title
|
@bassoy, what's your thought on moving trailing return type on to the next line for better readability. |
bassoy
changed the title
|
@Neel-Shah-29 could you indent the trailing return type a bit. |
I have brought the trailing return type to next line , do i need to indent it more towards the left side. |
Yes, but indent toward the right side. From auto fn = ...
->To auto fn = ...
-> |
…ns in algorithms.cpp Compiler cannot perform small-object and other optimizations in algorithms.cpp . This is solved by providing the trailing return type and passing the lambda through one of its arguments. Fixes #150
Done with all the changes which were suggested . Kindly have a look once. Thankyou |
This PR fixes issue #150 by providing the trailing return type and passing the lambda through one of its arguments.