Inheriting std::iterator is deprecated in c++17. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therefore get rid of all of that and replace inheritance by lifting std::iterator's members into the derived class. Signed-off-by: Daniela Engert <dani@ngrt.de>
danieljames
added a commit
that referenced
this pull request
Feb 25, 2018
- Various CI improvements, including appveyor support - Stop using boost::next in tests, because of warnings - Use std::iterator_traits, to drop dependency on iterator - Use std::piecewise_construct from dinukumware/Visual C++ - Template deduction guides, just copied from the standard, they don't work that well. I think some other implementations enhance them - Some internal changes - Stop inheriting from std::iterator, deprecated in C++17 (#7) - Implement allocator_traits::is_always_equal - Rewrite node handles using a simple class based on std::optional, so that it's closer to the standard - noexcept support for swap, operator= - Fix some compiler warnings - Fix some of the tests on Visual C++ 7.1 - Add element_type to iterators, so that pointer_traits will work - Use boost::to_address internally, instead of own custom implementation - Stop using BOOST_DEDUCED_TYPENAME - it's for very old compilers that are no longer supported, and makes the code look ugly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore get rid of all of that and replace inheritance by lifting std::iterator's members into the derived class.
Signed-off-by: Daniela Engert dani@ngrt.de