Fix man page generation #1628
Merged
Fix man page generation #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke this a while ago. Signed-off-by: Colin Walters <walters@verbum.org>
Since we do build from them Signed-off-by: Colin Walters <walters@verbum.org>
Since debugging the last failure was painful with just "No such file or directory" Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a series of valuable improvements to the man page generation process and the associated xtask tooling. The changes enhance robustness and developer experience by fixing a Docker cache path, improving error reporting with more context and colored output, and refactoring temporary file handling to be safer. The logic for conditionally using release builds is also a nice performance touch. Overall, these are solid enhancements. I have one minor suggestion to further improve robustness by replacing a call to unwrap().
Merged
jeckersb
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1627