test: Fix packit-reboot.yml download URL issue #1664
Conversation
Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the download URL for the packit-reboot.yml ansible playbook to point to the main bootc-dev/bootc repository. My review includes one suggestion to improve the stability of this test dependency by pinning the URL to a specific commit hash instead of the main branch. This will make the tests more reliable and prevent unexpected failures due to upstream changes.
| - how: ansible | ||
| playbook: | ||
| - https://github.com/henrywang/bootc/raw/refs/heads/gating/hack/packit-reboot.yml | ||
| - https://github.com/bootc-dev/bootc/raw/refs/heads/main/hack/packit-reboot.yml |
There was a problem hiding this comment.
While this change correctly points to the canonical repository, fetching the playbook from the main branch can cause test instability. If the remote packit-reboot.yml file changes, this test may break unexpectedly. For improved reliability and reproducible builds, it's best practice to pin the URL to a specific commit SHA instead of a branch name.
For example, you could use a URL like:
https://github.com/bootc-dev/bootc/raw/<full-commit-hash>/hack/packit-reboot.yml
There was a problem hiding this comment.
This is a really simple playbook for reboot, no additional code included. So no need to pin to commit.
| - how: ansible | ||
| playbook: | ||
| - https://github.com/henrywang/bootc/raw/refs/heads/gating/hack/packit-reboot.yml | ||
| - https://github.com/bootc-dev/bootc/raw/refs/heads/main/hack/packit-reboot.yml |
There was a problem hiding this comment.
Wait but can't we just specify running the playbook from the local git checkout?
There was a problem hiding this comment.
Two reasons:
- According to https://tmt.readthedocs.io/en/stable/plugins/prepare.html#ansible, I can't trace the git checkout folder. Very sad thing for me.
- The Fedora CI and OSCI gating does not have local git. I need extract
.src.rpm. And it does not work withansibleprepare.
There was a problem hiding this comment.
And I'm working on another PR to use .src.rpm instead of local git checkout. Just for working with dist-git gating test.
There was a problem hiding this comment.
I can't trace the git checkout folder. Very sad thing for me.
What do you mean "trace"? Oh...are you getting hit by
Line 17 in 3fd43a7
We can add
hack/ there too.
The Fedora CI and OSCI gating does not have local git. I need extract .src.rpm. And it does not work with ansible prepare.
Hmm. I often go back to referencing https://cockpit-project.org/blog/fmf-unified-testing.html
Though it looks like things have changed there for cockpit nowadays....
I also looked at https://src.fedoraproject.org/rpms/dnf5/blob/rawhide/f/.packit.yaml#_85 which is interesting.
Anyways I think the idea here is we should definitely be able to store this in a git repo directly.
There was a problem hiding this comment.
The dnf5 fedora dist-git does not have gating test for release PR, like https://src.fedoraproject.org/rpms/dnf5/pull-request/102.
PR #1642 merged, so the
packit-reboot.ymlansible playbook download URL should be moved tobootc-dev/bootcnow.