Skip to content

test: Fix packit-reboot.yml download URL issue #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

test: Fix packit-reboot.yml download URL issue #1664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tmt/plans/integration.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ prepare:
# reboot in ansible is the only way to reboot in tmt prepare
- how: ansible
playbook:
- https://github.com/henrywang/bootc/raw/refs/heads/gating/hack/packit-reboot.yml
- https://github.com/bootc-dev/bootc/raw/refs/heads/main/hack/packit-reboot.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly points to the canonical repository, fetching the playbook from the main branch can cause test instability. If the remote packit-reboot.yml file changes, this test may break unexpectedly. For improved reliability and reproducible builds, it's best practice to pin the URL to a specific commit SHA instead of a branch name.

For example, you could use a URL like:
https://github.com/bootc-dev/bootc/raw/<full-commit-hash>/hack/packit-reboot.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really simple playbook for reboot, no additional code included. So no need to pin to commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait but can't we just specify running the playbook from the local git checkout?

Copy link
Collaborator Author

@henrywang henrywang Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two reasons:

  1. According to https://tmt.readthedocs.io/en/stable/plugins/prepare.html#ansible, I can't trace the git checkout folder. Very sad thing for me.
  2. The Fedora CI and OSCI gating does not have local git. I need extract .src.rpm. And it does not work with ansible prepare.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I'm working on another PR to use .src.rpm instead of local git checkout. Just for working with dist-git gating test.

Copy link
Collaborator

@cgwalters cgwalters Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't trace the git checkout folder. Very sad thing for me.

What do you mean "trace"? Oh...are you getting hit by

bootc/tests/run-tmt.sh

Line 17 in 3fd43a7

# Move the tmt bits to a subdirectory to work around https://github.com/teemtee/tmt/issues/4062
?
We can add hack/ there too.

The Fedora CI and OSCI gating does not have local git. I need extract .src.rpm. And it does not work with ansible prepare.

Hmm. I often go back to referencing https://cockpit-project.org/blog/fmf-unified-testing.html

Though it looks like things have changed there for cockpit nowadays....

I also looked at https://src.fedoraproject.org/rpms/dnf5/blob/rawhide/f/.packit.yaml#_85 which is interesting.

Anyways I think the idea here is we should definitely be able to store this in a git repo directly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dnf5 fedora dist-git does not have gating test for release PR, like https://src.fedoraproject.org/rpms/dnf5/pull-request/102.

execute:
how: tmt

Expand Down