Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt tag in new component Avatar #4990

Closed
ghost opened this issue Mar 23, 2020 · 3 comments · Fixed by #4991, tghelere/CL#24, mariazevedo88/hash-generator-js#45, OpenTMI/opentmi-default-gui#58 or OpenTMI/opentmi-default-gui#60
Closed

Alt tag in new component Avatar #4990

ghost opened this issue Mar 23, 2020 · 3 comments · Fixed by #4991, tghelere/CL#24, mariazevedo88/hash-generator-js#45, OpenTMI/opentmi-default-gui#58 or OpenTMI/opentmi-default-gui#60
Labels
Type: Enhancement

Comments

@ghost
Copy link

@ghost ghost commented Mar 23, 2020

Is your feature request related to a problem? Please describe...

There is no way to add an ALT tag to the new Avatar Component resulting in a lower SEO ranking when using :src or src attribute in the component

Describe the solution you'd like

Please add :alt or alt in the Avatar component for images, like :src

Describe alternatives you've considered

I have added an alt tag in avatar component, but it adds it to the <span tag

Additional context

avatar-component
@tmorehouse tmorehouse added PR: Minor Type: Enhancement and removed PR: Minor labels Mar 23, 2020
tmorehouse added a commit that referenced this issue Mar 23, 2020
@tmorehouse
feat(b-avatar): add img-alt prop for adding alt attribute to image …
a060cdb 
…avatars (closes #4990)
@tmorehouse tmorehouse mentioned this issue Mar 23, 2020
Merged
20 tasks
@ghost
Copy link
Author

@ghost ghost commented Mar 23, 2020

@tmorehouse Thank you so much and keep up the great work, Bootstrap-Vue is AWESOME ! :-)

@tmorehouse tmorehouse added this to To do in 2.9.0 Mar 23, 2020
2.9.0 automation moved this from To do to Done Mar 23, 2020
jacobmllr95 added a commit that referenced this issue Mar 23, 2020
@tmorehouse @jacobmllr95
feat(b-avatar): add alt prop for adding alt attribute to image and …
d1474f2 
…icon avatars (closes #4990) (#4991)

* feat(b-avatar): add `img-alt` prop for adding alt attribute to image avatars (closes #4990)

* Update package.json

* Update avatar.js

* Update package.json

* Update avatar.js

* Update avatar.js

* Update avatar.js

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
@tmorehouse tmorehouse mentioned this issue Mar 23, 2020
Merged
@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 26, 2020

@Ozkaa BootstrapVue v2.9.0 has been released.

@ghost
Copy link
Author

@ghost ghost commented Mar 26, 2020

@tmorehouse Thank you so much, you guys rock!
Stay safe, Oscar

@snyk-bot snyk-bot mentioned this issue Apr 17, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 17, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 20, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
No open projects
2.9.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(b-avatar): add alt prop for adding alt attribute to image and icon avatars (closes #4990) bootstrap-vue/bootstrap-vue
[Snyk] Upgrade bootstrap-vue from 2.8.0 to 2.9.0 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.8.0 to 2.9.0 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.8.0 to 2.9.0 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 CodeForBaltimore/Healthcare-Rollcall
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.15 to 2.13.0 leonyork/cognito-oauth2-demo
1 participant
@tmorehouse