Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some new loss functions #1597

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

NaivelyWritten
Copy link

This PR adds some new loss functions that is asymmetric, similar to the L2WithDeadZone already exists.

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at least one test?

@NaivelyWritten
Copy link
Author

Add the unit test @dellaert

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ProfFan ProfFan merged commit eb0460a into borglab:develop Aug 1, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants