Override print methods #760
Conversation
varunagrawal
commented
Apr 29, 2021
varunagrawal
commented
- Override print methods.
- Update wrapper.
varunagrawal
added
python
gtsam/discrete/DiscreteFactor.h
Outdated
| const KeyFormatter& formatter = DefaultKeyFormatter) const { | ||
| Factor::print(s, formatter); | ||
| virtual void print( |
gtsam/linear/GaussianBayesNet.h
Outdated
| @@ -177,6 +177,13 @@ namespace gtsam { | |||
| */ | |||
| VectorValues backSubstituteTranspose(const VectorValues& gx) const; | |||
|
|
|||
| /// print graph | |||
| virtual void print( | |||
There was a problem hiding this comment.
no virtual. I recommend checking the warnings in a clang CI run to be sure I did not miss anything.
There was a problem hiding this comment.
Great idea. And yes I'll get rid of the virtuals where there are overrides.
gtsam/linear/GaussianFactor.h
Outdated
| const KeyFormatter& formatter = DefaultKeyFormatter) const = 0; | ||
|
|
||
| virtual void print( |
gtsam/nonlinear/NonlinearFactor.h
Outdated
| @@ -70,8 +70,9 @@ class GTSAM_EXPORT NonlinearFactor: public Factor { | |||
| /// @{ | |||
|
|
|||
| /** print */ | |||
| virtual void print(const std::string& s = "", | |||
| const KeyFormatter& keyFormatter = DefaultKeyFormatter) const; | |||
| virtual void print( | |||
| @@ -63,6 +63,13 @@ namespace gtsam { | |||
| /** Check equality */ | |||
| GTSAM_EXPORT bool equals(const This& bn, double tol = 1e-9) const; | |||
|
|
|||
| GTSAM_EXPORT void print( | |||
There was a problem hiding this comment.
Why is this the only one with GTSAM_EXPORT? Should we have that everywhere?
There was a problem hiding this comment.
That's a good question. My intent was to be consistent (since equals in this case is qualified with GTSAM_EXPORT) but it would be good to have a good hard look in a subsequent PR? I know Windows people will have all sorts of issues due to the lack of GTSAM_EXPORT.
|
I had to add a bunch of virtual destructors to satisfy the compiler's warnings, but all the warnings with Clang have been addressed. 🎉 |
