Fix retry logic #787

sujaygarlanka · 2020-04-01T21:33:55Z

Fix retry logic

Retry for 400 invalid_grant error in authentication requests (Clock Skew)
Honor Retry-After header if present by waiting for the time specified in the header before retrying
Number of request retries after the initial request is now equal to the DEFAULT_MAX_ATTEMPTS config value

coveralls · 2020-04-01T21:59:56Z

Pull Request Test Coverage Report for Build 2174

43 of 60 (71.67%) changed or added relevant lines in 6 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.05%) to 65.602%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/main/java/com/box/sdk/BoxDeveloperEditionAPIConnection.java	6	7	85.71%
src/main/java/com/box/sdk/BoxAPIRequest.java	21	24	87.5%
src/main/java/com/box/sdk/BoxGlobalSettings.java	3	6	50.0%
src/main/java/com/box/sdk/BoxAPIConnection.java	11	16	68.75%
src/main/java/com/box/sdk/SharedLinkAPIConnection.java	0	5	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/main/java/com/box/sdk/SharedLinkAPIConnection.java	1	0%
src/main/java/com/box/sdk/BoxAPIRequest.java	2	65.38%

Totals
Change from base Build 2172:	0.05%
Covered Lines:	5527
Relevant Lines:	8425

💛 - Coveralls

CHANGELOG.md

src/main/java/com/box/sdk/BoxAPIRequest.java

src/main/java/com/box/sdk/BoxAPIConnection.java

src/main/java/com/box/sdk/BoxAPIRequest.java

src/test/Fixtures/BoxAPIConnection/State.json

src/test/java/com/box/sdk/BoxAPIConnectionTest.java

src/main/java/com/box/sdk/SharedLinkAPIConnection.java

src/main/java/com/box/sdk/BoxGlobalSettings.java

src/main/java/com/box/sdk/BoxAPIConnection.java

Co-Authored-By: Sujay Garlanka <sujay.garlanka@gmail.com>

src/main/java/com/box/sdk/BoxAPIConnection.java

src/main/java/com/box/sdk/BoxGlobalSettings.java

CHANGELOG.md

src/main/java/com/box/sdk/BoxAPIConnection.java

src/main/java/com/box/sdk/SharedLinkAPIConnection.java

sujaygarlanka added 4 commits April 1, 2020 16:54

done

dc65ef7

update changelog

3e94b0c

Update CHANGELOG.md

1e9317b

clean up code and tests passing

04c255c

sujaygarlanka and others added 2 commits April 6, 2020 12:56

Merge branch 'master' into amend-retry-logic

043690d

Refactor waitBackoff()

e01a359

PJSimon reviewed Apr 6, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

src/main/java/com/box/sdk/BoxAPIRequest.java Outdated Show resolved Hide resolved

PJSimon reviewed Apr 7, 2020

View reviewed changes

src/main/java/com/box/sdk/BoxAPIConnection.java Show resolved Hide resolved

PJSimon reviewed Apr 7, 2020

View reviewed changes

src/main/java/com/box/sdk/BoxAPIRequest.java Show resolved Hide resolved

PJSimon force-pushed the amend-retry-logic branch from 534e6ee to e01a359 Compare April 7, 2020 21:48

PJSimon and others added 3 commits April 7, 2020 14:50

Update CHANGELOG

a752323

Merge branch 'master' into amend-retry-logic

c5ad4d4

add check for retrying requests

451e878

PJSimon reviewed Apr 7, 2020

View reviewed changes

src/main/java/com/box/sdk/BoxAPIRequest.java Show resolved Hide resolved

sujaygarlanka and others added 3 commits April 7, 2020 19:24

code clean up

446386a

refactor code

b3b60c6

Refactor 'Max Attempts' to 'Max Retries'

994d9c1

PJSimon reviewed Apr 8, 2020

View reviewed changes

src/test/Fixtures/BoxAPIConnection/State.json Show resolved Hide resolved

PJSimon reviewed Apr 8, 2020

View reviewed changes

src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated Show resolved Hide resolved

Update src/test/java/com/box/sdk/BoxAPIConnectionTest.java

87dd670

PJSimon previously approved these changes Apr 8, 2020

View reviewed changes

Fix Test

e466b6c

PJSimon dismissed their stale review via e466b6c April 9, 2020 03:09

PJSimon previously approved these changes Apr 9, 2020

View reviewed changes