-
Notifications
You must be signed in to change notification settings - Fork 235
[MRG] Include EEGSym #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Include EEGSym #697
Conversation
|
@bruAristimunha its not working yet. The model integration test should fail (because of the number of filters or kernel sizes, not sure) |
|
yeah yeah. I can incorporate a small benchmark with physionet to reproduce the results when you tell me it works |
|
Let's wait for @Serpeve's input to figure out the filters and kernel sizes, and make sure this pytorch re-implementation is consistent with his original tensorflow one before we merge |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 87.18% 87.43% +0.25%
==========================================
Files 99 101 +2
Lines 8406 8614 +208
==========================================
+ Hits 7329 7532 +203
- Misses 1077 1082 +5 🚀 New features to boost your workflow:
|
|
Thanks @PierreGtch :) |
|
Thanks for the PR @bruAristimunha !!! FYI @Serpeve your model is in braindecode :D |
Follow-up on #664
I fixed the channel split
Also, the time and channel dimensions were inverted in the convolutions which I fixed
However I don't understand why
in_channels!=filtersin the residual blocks. It does not seem possible because of the resudual connections.@Serpeve could you have a look? In particular if the
in_channels,out_channelsandkernel_sizeare consistent with your original implementationCC @bruAristimunha