Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

MOABB deprecated BNCI2014001 in favor of BNCI2014_001 and will remove the old name in v1.1.

Changes

  • Class definition: Renamed BNCI2014001BNCI2014_001 in braindecode/datasets/moabb.py
  • Dataset string references: Updated all dataset_name="BNCI2014001"dataset_name="BNCI2014_001" across examples and tests (7 example files, 4 test files)
  • Imports: Updated imports and __all__ exports in braindecode/datasets/__init__.py
  • Documentation: Updated API reference in docs/api.rst

Migration

Old code:

from braindecode.datasets import BNCI2014001
dataset = BNCI2014001([1])
# or
dataset = MOABBDataset(dataset_name="BNCI2014001", subject_ids=[1])

New code:

from braindecode.datasets import BNCI2014_001
dataset = BNCI2014_001([1])
# or
dataset = MOABBDataset(dataset_name="BNCI2014_001", subject_ids=[1])

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bnci-horizon-2020.eu
    • Triggering command: python -m pytest test/unit_tests/datasets/test_moabb.py::test_BNCI2014_001 -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Improved code health: rename the deprecated dataset name in Moabb.</issue_title>
<issue_description>WARNING (moabb.utils) BNCI2014001 has been renamed to BNCI2014_001. BNCI2014001 will be removed in version 1.1.</issue_description>

Comments on the Issue (you are @copilot in this section)

@bruAristimunha This is done in all tutorials, and every time it's mentioned in the codebase.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename deprecated dataset name in Moabb Rename deprecated BNCI2014001 to BNCI2014_001 Nov 6, 2025
Copilot AI requested a review from bruAristimunha November 6, 2025 00:47
Copilot finished work on behalf of bruAristimunha November 6, 2025 00:47
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.45%. Comparing base (4e71d23) to head (499fae6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         101      101           
  Lines        8614     8618    +4     
=======================================
+ Hits         7533     7537    +4     
  Misses       1081     1081           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruAristimunha bruAristimunha marked this pull request as ready for review November 6, 2025 01:28
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bruAristimunha bruAristimunha merged commit 7f68bdd into master Nov 6, 2025
17 checks passed
@bruAristimunha bruAristimunha deleted the copilot/rename-deprecated-dataset-name branch November 6, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved code health: rename the deprecated dataset name in Moabb.

2 participants