brave://settings has two Widevine settings and it's not obvious what they do

[bsclifton]

Test plan

Install happy path

1. Fresh profile
2. Visit brave://settings and verify Widevine is disabled
3. Visit Netflix, login, and watch something
4. Verify you see a prompt
5. Accept the prompt / install Widevine
6. Visit brave://settings and verify Widevine is enabled

Deny prompt path

1. Fresh profile
2. Visit brave://settings and verify Widevine is disabled
3. Visit Netflix, login, and watch something
4. Verify you see a prompt
5. Tick the Never show this again box and deny access
6. Verify video doesn't load
7. Refresh page or visit another video
8. Verify prompt not shown again
9. Visit brave://settings and manually enable Widevine
10. Visit another video and verify it plays as expected (no prompt)

Description

Discovered by @GeetaSarvadnya:

With the recent addition of Enable Widevine by @simonhong with brave/brave-core#7554, there are now two toggles:

• One is toggling whether or not to show a prompt when Widevine is requested to be used
• One is toggling whether Widevine is actively installed or not (if disabled, it will uninstall the binaries)

A few ways to resolve:

1. Only show one of these
2. Find a better way to reword or rephrase each setting

[bsclifton]

Per Slack discussion https://bravesoftware.slack.com/archives/C7VLGSR55/p1612981235355800?thread_ts=1612956954.340600&cid=C7VLGSR55

I think we can probably remove the Ask when a site wants to install Widevine on your computer setting. We just need to choose what to do in that case when a user visits a Widevine site and has Widevine disabled

1. Should we still show the prompt to them?
2. If not and they forgot they disabled - how would they know we're respecting their preference and they aren't experiencing a bug (should we show a visual indicator? this might already be present for Widevine items)

[karenkliu]

We should keep showing the Widevine prompt unless they have clicked on "Don't show again" checkbox in the prompt.

[stephendonner]

Verified FIXED on nightly on macOS Big Sur (11.2.1) with

Brave	1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.1 (Build 20D74)

Install happy path

• Fresh profile
• Visit brave://settings and verify Widevine is disabled

• Visit Netflix, log in, and watch something

• Verify you see a prompt

• Accept the prompt / install Widevine

• Visit brave://settings and verify Widevine is enabled

Deny-prompt path

• Fresh profile
• Visit brave://settings and verify Widevine is disabled

• Visit Netflix, log in, and watch something
• Verify you see a prompt
• Tick the Don't ask again box and deny access by clicking Block

• Verify video doesn't load

• Refresh page or visit another video

• Verify prompt not shown again

• Visit brave://settings and manually enable Widevine

* Visit another video and verify it plays as expected (no prompt)

---

Verification passed on

Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Verified the test plan mentioned in the description

Install happy path

• Ensured Widevine setting is disabled by default in brave://settings
  
• Ensured install Widevine prompt is shown when netflix is logged in
  
• Ensured Widevine settings is enabled in brave://settings when the widevine install prompt is accepted
  
• Ensured that netflix videos are being played
  

Deny-prompt path

• Ensured Widevine setting is disabled by default in brave://settings
  

• Ensured install Widevine prompt is shown when netflix is logged in
  

• Ensured that install Widevine prompt isn't shown again when the Don't ask again checkbox is checked and the Blocked option is selected in the prompt
  

• Ensured that videos cannot be played when install Widevine prompt is denied
  

• Ensured that install Widevine prompt isn't shown again when another video is visited

• Ensured Widevine setting is disabled in brave://settings

• Ensured that videos are being played when Widevine is enabled from brave://settings

---

Verification passed on

Brave	1.21.64 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	Ubuntu 18.04 LTS

• Verified the test plan mentioned in the description

Install happy path

• Ensured Widevine setting is disabled by default in brave://settings
  
• Ensured install Widevine prompt is shown when netflix is logged in
  
• Ensured Widevine settings is enabled in brave://settings when the widevine install prompt is accepted
  
• Ensured that netflix videos are being played
  

Deny-prompt path

• Ensured Widevine setting is disabled by default in brave://settings
  

• Ensured install Widevine prompt is shown when netflix is logged in
  

• Ensured that install Widevine prompt isn't shown again when the Don't ask again checkbox is checked and the Blocked option is selected in the prompt
  

• Ensured that videos cannot be played when install Widevine prompt is denied
  

• Ensured that install Widevine prompt isn't shown again when another video is visited

• Ensured Widevine setting is disabled in brave://settings

• Ensured that videos are being played when Widevine is enabled from brave://settings