-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrome:// urls should display as brave:// #1458
Labels
Milestone
Comments
18 tasks
bbondy
pushed a commit
to brave/brave-core
that referenced
this issue
Oct 12, 2018
This only affects the DisplayURL in that, when the url is being edited or copied, the actual chrome://*** url will be present. This seems acceptable given: - These urls 99% of the time are for display purposes only, as a result of another UI action, and will not be typed manually - We intend to support brave://*** actual urls, redirecting to chrome://*** actual URLs automatically, which will get displayed as brave://*** URLs (brave/brave-browser#810) Fix brave/brave-browser#1458
petemill
added a commit
to brave/brave-core
that referenced
this issue
Oct 13, 2018
This only affects the DisplayURL in that, when the url is being edited or copied, the actual chrome://*** url will be present. This seems acceptable given: - These urls 99% of the time are for display purposes only, as a result of another UI action, and will not be typed manually - We intend to support brave://*** actual urls, redirecting to chrome://*** actual URLs automatically, which will get displayed as brave://*** URLs (brave/brave-browser#810) Fix brave/brave-browser#1458
Verification Passed on
Went through verification using the following build under
Verification Passed on
|
18 tasks
This was referenced Jan 25, 2023
50 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
It may be too much work to redirect all chrome:// urls to brave:// and have the appropriate handlers and checks still work reliable.
Luckily, the ToolbarModel provides GetURLForDisplay which can be overridden so that brave:// displays most of the time (until the URL is edited).
When paired with #810 this should cover quite a bit of the requirement to support brave:// URLs without confusing the users about the chromium-based core.
Test plan:
Displays brave:// url
brave://welcome
as the address in LocationBarEdits chrome:// url
brave://
prefix in LocationBarCopies chrome:// url
brave://
prefix in LocationBarThe text was updated successfully, but these errors were encountered: