Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to import from Google Chrome Beta #14609

Closed
TotallyNotSethP opened this issue Mar 9, 2021 · 10 comments · Fixed by brave/brave-core#15065
Closed

Add ability to import from Google Chrome Beta #14609

TotallyNotSethP opened this issue Mar 9, 2021 · 10 comments · Fixed by brave/brave-core#15065
Assignees
@bsclifton
Labels
feature/importer OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@TotallyNotSethP
Copy link

Description

I just got Brave Browser and noticed that I couldn't transfer my data from Google Chrome Beta. I should be able to!

Steps to Reproduce

  1. Get Google Chrome Beta and set it up
  2. Go to "brave://settings/importData" in Brave Browser
  3. Click the dropdown. Google Chrome Beta isn't in the list.

Actual result:

Google Chrome Beta isn't in the list of browsers to transfer from.

Expected result:

Google Chrome Beta is in the list of browsers to transfer from.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.21.74 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A (Can't transfer from Chrome to Chrome)

Miscellaneous Information:
@srirambv
Copy link
Contributor

Similar to #1357

cc: @rebron

@rebron
Copy link
Collaborator

rebron commented Mar 16, 2021

cc: @kjozwiak Need more investigation on this one. Profiles should showed up but not necessarily showing which channel.

@TotallyNotSethP
Copy link
Author

The profiles do not show up at all.

@srirambv
Copy link
Contributor

@rebron if am not wrong this is an issue with Chromium and not just Brave. Chrome Dev doesn't even recognise Chrome release channel. Here's a screenshot of Chrome Dev build
image

@kjozwiak
Copy link
Member

kjozwiak commented Mar 17, 2021 •
edited
Loading

So it looks like Brave only adds Chrome/Canary into Import Data but isn't finding Chrome Beta & Chrome Dev. Examples:

Installed Version:

  • 89.0.4389.82 (Official Build) (64-bit) (cohort: Stable)
  • 90.0.4430.19 (Official Build) beta (64-bit) (cohort: Beta)
  • 91.0.4442.4 (Official Build) dev (64-bit) (cohort: Dev)
  • 91.0.4449.0 (Official Build) canary (64-bit) (cohort: Clang-64)

What Brave is finding via brave://settings/importData:

Example Example
import2 import1

Regarding what @srirambv mentioned above, that's related to #1357 re: Chromium not finding other channels. The above is an about Brave not finding another browser, specifically Chrome Beta & Chrome Dev.

Looks like Edge & Firefox also have issues finding other browsers:

Edge Firefox
image image
  • Edge - not finding Brave, Chrome Beta, Chrome Dev & Chrome Canary
  • Firefox - not finding Brave & Chrome Dev

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Mar 23, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2021 •
edited
Loading

@bsclifton @rebron should we maybe move this to a P3 as we want users to have a seamless experience when migrating from other browsers? Maybe Chrome BETA doesn't have the userbase as Chrome but assuming it's still pretty big. Either way, I'm fine with P4 but figured we might want to get this fixed sooner than later as part of user retention efforts 👍

Might not be an easy task though as it looks like other browsers are struggling picking up other Chrome channels as well.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 9, 2022
@bsclifton
Copy link
Member

Confirmed this is still an issue; Canary and Stable channel both import just fine

@bsclifton bsclifton self-assigned this Sep 12, 2022
@bsclifton bsclifton changed the title Can't Transfer From Google Chrome Beta Add ability to import From Google Chrome Beta Sep 12, 2022
@bsclifton bsclifton mentioned this issue Sep 12, 2022
Merged
25 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Sep 12, 2022
@bsclifton
Add Chrome Beta as an import source
afbbf19 
Fixes brave/brave-browser#14609
@bsclifton bsclifton added this to the 1.45.x - Nightly milestone Sep 12, 2022
@bsclifton bsclifton changed the title Add ability to import From Google Chrome Beta Add ability to import from Google Chrome Beta Sep 12, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 28, 2022
@stephendonner
Copy link

stephendonner commented Sep 28, 2022 •
edited
Loading

Verification PASSED using

Brave 1.45.77 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Prerequisite Steps:

Google Chrome Beta installed, seeded the following two profiles:

  • Unique User 1
  • Unique User 2

Both of which have 2 (or more):

  • bookmarks
  • extensions
  • browsing history
  • saved passwords

Case 1: brave://welcome import - PASSED

Steps:

  1. installed 1.45.77
  2. launched Brave
  3. clicked Let's go ->
  4. selected Chrome Beta Unique User 1
  5. clicked on Import
  6. clicked Done

Confirmed the following were successfully imported:

  • bookmarks/favorites
  • extensions
  • browsing history
  • saved passwords

Unique User 1

brave://welcome bookmarks extensions history passwords
Screen Shot 2022-09-28 at 5 42 10 PM Screen Shot 2022-09-28 at 3 57 39 PM Screen Shot 2022-09-28 at 3 57 55 PM Screen Shot 2022-09-28 at 3 57 28 PM Screen Shot 2022-09-28 at 3 57 00 PM

Unique User 2

brave://welcome bookmarks extensions history passwords
Screen Shot 2022-09-28 at 5 45 06 PM Screen Shot 2022-09-28 at 4 24 42 PM Screen Shot 2022-09-28 at 4 25 03 PM Screen Shot 2022-09-28 at 4 24 24 PM Screen Shot 2022-09-28 at 4 31 25 PM

Case 2: Brave -> Import Bookmarks and Settings... - PASSED

Steps:

  1. installed 1.45.77
  2. launched Brave
  3. clicked OS/app-level Brave menu item -> Import Bookmarks and Settings
  4. selected Chrome Beta Unique User 1
  5. clicked on Import
  6. clicked Done

Confirmed the following were successfully imported:

  • bookmarks/favorites
  • extensions
  • browsing history
  • saved passwords
brave://settings/importData, 1 brave://settings/importData, 2
Screen Shot 2022-09-28 at 8 16 08 PM Screen Shot 2022-09-28 at 8 36 28 PM
bookmarks extensions history passwords
Screen Shot 2022-09-28 at 8 38 43 PM Screen Shot 2022-09-28 at 8 40 16 PM Screen Shot 2022-09-28 at 8 39 54 PM Screen Shot 2022-09-28 at 8 39 20 PM

Case 3: Main menu -> Bookmarks -> Import Bookmarks and Settings... - PASSED

This entrypoint (which redirects to brave://settings/importData) is invoked by (and tested in) the Case 2: Brave -> Import Bookmarks and Settings test

Case 4: brave://settings/importData - PASSED

This entrypoint is invoked by (and tested in) the Case 2: Brave -> Import Bookmarks and Settings... test

Case 5: Deselection of two (2) import types - PASSED

Steps:

  1. installed 1.45.77
  2. launched Brave
  3. clicked OS/app-level Brave menu item -> Import Bookmarks and Settings
  4. selected Chrome Beta Unique User 1
  5. clicked on Import
  6. de-selected Browsing history
  7. de-selected Saved passwords
  8. clicked Import
  9. clicked Done

Confirmed the following were successfully imported:

  • bookmarks
  • extensions

Confirmed the following were NOT imported:

  • browsing history (entries in screenshot are from imported extensions opening their "welcome" tabs)
  • saved passwords
brave://settings/importData bookmarks extensions history passwords
Screen Shot 2022-09-28 at 10 07 22 PM Screen Shot 2022-09-28 at 10 08 21 PM Screen Shot 2022-09-28 at 9 57 03 PM Screen Shot 2022-09-28 at 9 56 23 PM Screen Shot 2022-09-28 at 9 58 01 PM

Case 6: Import a single category type - PASSED

Steps:

  1. installed 1.45.77
  2. launched Brave
  3. clicked OS/app-level Brave menu item -> Import Bookmarks and Settings
  4. selected Chrome Beta Unique User 1
  5. clicked on Import
  6. de-selected Browsing history
  7. de-selected Favorites/Bookmarks
  8. de-selected Extensions
  9. clicked Import
  10. clicked Done

Confirmed the following was imported:

  • saved passwords

Confirmed the following were not imported:

  • browsing history
  • favorites/bookmarks
  • extensions
brave://settings/importData bookmarks extensions history passwords
Screen Shot 2022-09-28 at 10 25 28 PM Screen Shot 2022-09-28 at 10 27 27 PM Screen Shot 2022-09-28 at 10 27 50 PM Screen Shot 2022-09-28 at 10 27 55 PM Screen Shot 2022-09-28 at 10 28 34 PM

@LaurenWags
Copy link
Member

@stephendonner @MadhaviSeelam let's be sure to check this one on Windows and macOS 👍🏻

@stephendonner stephendonner added OS/Windows OS/macOS QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 4, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.45.84 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 21H2 (Build 22000.978)

Prerequisite Steps:

Google Chrome Beta installed, seeded the following two profiles:

  • Person 1 -
    • bookmarks/favorites
    • extensions
    • browsing history
    • saved passwords
  • Person 2
    • bookmarks/favorites
    • extensions
    • browsing history

Case 1: Multiple profiles - brave://welcome import - PASSED

Steps:

  1. installed 1.45.84
  2. launched Brave
  3. clicked Let's go ->
  4. selected Chrome Beta Person 1
  5. clicked on Import
  6. clicked Done

Confirmed the following were successfully imported:

  • bookmarks/favorites
  • extensions
  • browsing history
  • saved passwords

Person 1

step 3 step 4 bookmarks extensions browsing history saved passwords
image image image image image image

Person 2

step 4 bookmarks browsing history saved passwords
image image image image

Case 2: Single profile - Brave://settings -> Import Bookmarks and Settings - PASSED

Steps:

  1. new profile
  2. launched Brave
  3. open brave://settings -> Import Bookmarks and Settings
  4. selected Chrome Beta Person 2
  5. clicked on Import
  6. clicked Done

Confirmed the following were successfully imported:

  • bookmarks/favorites
  • extensions
  • browsing history
step4 bookmarks history extensions
image image image image

Case 3: Deselection of two (2) import types - import from the bookmarks bar link - PASSED

Steps:

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. click Import bookmarks now.. link on the bookmarks bar
  5. selected Chrome Beta Person 1
  6. de-selected Browsing history
  7. de-selected Saved passwords
  8. clicked Import
  9. clicked Done
  10. confirmed browsing history and saved passwords are not imported

Confirmed the following were successfully imported:

  • bookmarks/favorites
  • extensions
step 4 step 5-9 bookmarks extensions
image image
image image

Case 4: Import a single category type - should Sync between profiles- PASSED

Steps:

profile 1

  1. new profile
  2. launched Brave
  3. clicked hamburger menu ->Bookmarks--> Import Bookmarks and Settings
  4. selected Chrome Beta Person 1
  5. de-selected Browsing history
  6. de- selected Saved passwords
  7. de-selected Extensions
  8. clicked Import
  9. clicked Done
  10. confirmed the Favorites/Bookmarks imported
  11. confirmed Browsing history, Extensions and Saved passwords not imported
  12. visit brave://sync
  13. click on Start using sync>> Start a new Sync Chain
  14. click Computer
  15. copy the code words
  16. under Sync Settings, leave default `Customize sync``
step 3 step4-9 step 10 step15 step 16
image image image image image

***profile 2 ** *

  1. go to device 2
  2. click on the hamburger menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from profile 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, leave default Customize sync toggle
  8. confirmed Favorites/Bookmarks, synced successfully
step 6 step 7 step 8
image image image

Case 5: Upgrade 1.44.105--->1.45.84

  1. install 1.44.105
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome Canary Person 1 in the Import bookmarks and settings modal
  5. keep default selections Browsing history, Saved passwords and complete import
  6. confirmed successful import of Browsing history, Saved Passwords, into Brave
  7. close the browser
  8. rename profile folder to Beta
  9. launch Brave with 1.45.84
  10. Browsing history, Saved Passwords are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. confirmed Chrome Beta - Person 1 and Person 2 are listed in the drop down menu of Import bookmarks and settings modal
  13. select Chrome Beta Person 1 and keep default selections of Browsing history, Favorites/Bookmarks, Saved passwords, Extensions
  14. complete import
  15. confirmed successfully imported from Browsing history, Favorites/Bookmarks, Saved passwords, Extensions
step 1 step 4- 5 browsing history saved passwords
image image image image
step 12 step 13-14 bookmarks/history extensions saved passwords
image image image image image

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
feature/importer OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Add importer support for Chrome Beta and Dev channels brave/brave-core
8 participants
@stephendonner @kjozwiak @bsclifton @rebron @TotallyNotSethP @srirambv @LaurenWags @MadhaviSeelam