Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad grant notification is not dismissed from NTP rewards widget after claiming it from brave://rewards #15146

Closed
LaurenWags opened this issue Apr 6, 2021 · 5 comments · Fixed by brave/brave-core#12194
Assignees
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Seems to be very similar to #6755

I just claimed this month's Ad grant from brave://rewards page and when I open new tabs the Rewards widget tells me that I have a grant to claim.

Steps to Reproduce

  1. Have an ad grant waiting to be claimed
  2. Open a NTP so you get the notification on NTP widget (I think this part might be important, steps from other issue did not have this in them)
  3. Go claim grant from brave://rewards (do not claim from widget)
  4. Open another NTP or refresh already opened NTP
  5. See that the panel notification for the ad grant has gone away, but look at widget

Actual result:

Widget still prompts to claim ad grant even though it was already claimed

Screen Shot 2021-04-06 at 9 10 01 AM

Expected result:

Prompt to claim ad grant should not show on widget after it has already been claimed

Reproduces how often:

Brave version (brave://version info)

Brave 1.23.59 Chromium: 89.0.4389.114 (Official Build) dev (x86_64)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS macOS Version 10.15.7 (Build 19H524)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes, 1.23.x
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member Author

This was not solved with the new widget, reproduces with 1.34.x

@LaurenWags
Copy link
Member Author

@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2022

Still an issue with the new rewards UI changes. Once ad grant is claimed the NTP widget notification is not dismissed nor can be manually closed

@zenparsing
Copy link

I was able to reproduce this in 1.37 using the following steps:

  • Start browser with rewards staging and a new profile.
  • Enable rewards from the panel.
  • Open NTP.
    • (A grant notification will be displayed.)
  • Close NTP.
  • Open brave://rewards
  • Claim grant.
  • Open NTP.
    • (The grant notification will still be displayed.)

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 9, 2022
@zenparsing zenparsing added this to the 1.37.x - Nightly milestone Feb 11, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 9, 2022

Verification PASSED on

Brave | 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1526)

Example Example Example
image image image
  • Confirmed that ad grants notification is removed from the NTP widget after claiming the ad grants from brave://rewards
NTP Before claiming ad grants NTP After claiming ad grants
image image

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants