Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNS link fails to load via "Load using IPFS" badge/icon in URL bar #16229

Closed
Tracked by #17112
stephendonner opened this issue Jun 3, 2021 · 1 comment · Fixed by brave/brave-core#9035
Closed
Tracked by #17112

Comments

@stephendonner
Copy link

Description

IPNS link fails to load via "Load using IPFS" badge/icon in URL bar

Found while testing #16115

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. click on the Open using IPFS badge/icon

Actual result:

ipns://brantly.eth//brantly.eth (note the double //) gets loaded in the URL bar, with the error message ipfs resolve -r /ipns/brantly.eth/brantly.eth: no link named "brantly.eth" under bafybeihqoo7bq7uoaybzpfwegks33vw2h5adyl4t7joz3pofkr6h7yhdxq printed out

Screen Shot 2021-06-03 at 10 22 25 AM

Expected result:

It should load the resource using IPFS

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.39 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

/cc @lidel @spylogsster

@stephendonner
Copy link
Author

Verified PASSED using the inline testplan with build

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. loaded ipns://brantly.eth
  4. clicked on Use a local node
  5. confirmed after install finished there was no Open using IPFS badge in the URL bar, since it's already using it
example example
Screen Shot 2021-06-14 at 11 27 09 AM Screen Shot 2021-06-14 at 11 27 22 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants