Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields UI refresh still shows blocked count when setting is off #21613

Closed
petemill opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12523
Closed

Shields UI refresh still shows blocked count when setting is off #21613

petemill opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12523

Comments

@petemill
Copy link
Member

Description

In brave://settings there is an option to not display the blocked count in the shields action icon. This is not respected by the shields refresh button.

image

Steps to Reproduce

  1. open settings
  2. turn "Show the number of blocked items on the Shields icon" off
  3. Go to a tab with blocked items

Actual result:

Blocked count is still shown

Expected result:

Blocked count is not shown

v 1.38.27

@rebron rebron changed the title [Desktop] Shields UI refresh still shows blocked count when setting is off Shields UI refresh still shows blocked count when setting is off Mar 11, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 11, 2022
@nullhook nullhook added this to the 1.38.x - Nightly milestone Mar 15, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.3 (Build 20G415)

Steps:

  1. install 1.38.60
  2. launched Brave
  3. loaded ign.com and clicked on an article
  4. confirmed I saw blocked count on the Shields icon
  5. confirmed Show the number of blocked items on the Shields icon is toggled to ON
  6. toggled the above to OFF
  7. reloaded the ign.com page
  8. confirmed I no longer saw the blocked count on the Shields icon
example example
Screen Shot 2022-03-22 at 1 47 05 PM Screen Shot 2022-03-22 at 1 47 28 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 1, 2022

Verified Passed using

Brave 1.38.77 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.593)
  • Install 1.38.77
  • launched Brave
  • Visited theverge.com and clicked on an article
  • confirmed I saw blocked count on the Shields icon
  • confirmed Show the number of blocked items on the Shields icon is toggled to ON
  • toggled the above to OFF
  • reloaded the theverge.com page
  • confirmed I no longer saw the blocked count on the Shields icon
ex1 ex2
blocked items turned off shields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants