Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message isn't dismissed when browser is closed #2484

Closed
srirambv opened this issue Dec 12, 2018 · 2 comments · Fixed by brave/brave-core#1152
Closed

Error message isn't dismissed when browser is closed #2484

srirambv opened this issue Dec 12, 2018 · 2 comments · Fixed by brave/brave-core#1152
Assignees
@cezaraugusto
Labels
bug feature/sync polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/not-blocking release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Error message isn't dismissed when browser is closed

Steps to Reproduce

  1. Disconnect device from network
  2. Open brave://bravesync and click on I am new to Sync
  3. Enter device name and click Setup Sync, shows error message
  4. Close browser without dismissing the popup notification
  5. Restart browser and open sync page and click on I am new to Sync, error popup message is retained

Actual result:

https://drive.google.com/open?id=1iCn5ZbFxvc9tVw3vivKiSPi0j7mm2LPF

Expected result:

Popup error message should be dismissed when browser is closed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added bug polish Nice to have — usually related to front-end/visual tasks feature/sync priority/P4 Planned work. We expect to get to it "soon". release/not-blocking QA/Yes release-notes/include labels Dec 12, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 12, 2018
@btlechowski
Copy link

btlechowski commented Dec 12, 2018 •
edited
Loading

Reproduced on Windows 7 x64

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 19, 2018
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 20, 2018
@cezaraugusto
dismiss all errors at sync start
3b8036d 
fix brave/brave-browser#2484
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 20, 2018
@darkdh darkdh modified the milestones: 0.60.x - Dev, 0.59.x - Beta Dec 20, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified the STR mentioned in description

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR mentioned in description

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/sync polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

dismiss all errors at sync start brave/brave-core
7 participants
@kjozwiak @cezaraugusto @darkdh @srirambv @LaurenWags @btlechowski @GeetaSarvadnya