Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change text on Tips panel #2499

Closed
rebron opened this issue Dec 12, 2018 · 1 comment · Fixed by brave/brave-core#1085
Closed

change text on Tips panel #2499

rebron opened this issue Dec 12, 2018 · 1 comment · Fixed by brave/brave-core#1085
Assignees
@NejcZdovc
Labels
feature/rewards needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 12, 2018 •
edited
Loading

Design/Screenshot

tips-panel-text

Description

  1. Go to brave://rewards and scroll to bottom.

Currently reads:
“Tip content creators directly as you browse or give tips to videos and tweets that you ‘like’. You can also set up recurring monthly tips so you can support sites continuously.”

Change text so it reads:
“Tip content creators directly as you browse. You can also set up recurring monthly tips so you can support sites continuously.”
@rebron rebron added this to the 0.58.x - Release milestone Dec 12, 2018
@rebron rebron added feature/rewards needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 12, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@NejcZdovc
Fixes tips box text
2078f69 
Resolves brave/brave-browser#2499
@NejcZdovc NejcZdovc mentioned this issue Dec 13, 2018
Merged
18 tasks
@rebron rebron removed this from the 0.58.x - Release milestone Dec 13, 2018
@NejcZdovc NejcZdovc added this to the 0.59.x - Beta milestone Dec 13, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 21, 2018 •
edited
Loading

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified changed text on tips panel
    image

Verified passed with

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta(64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Mac OS X

screen shot 2018-12-21 at 4 30 53 pm

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes tips box text brave/brave-core
5 participants
@bbondy @rebron @NejcZdovc @LaurenWags @GeetaSarvadnya