Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide non-working Safe Browsing setting on Android #25047

Closed
fmarier opened this issue Aug 29, 2022 · 1 comment · Fixed by brave/brave-core#14875
Closed

Hide non-working Safe Browsing setting on Android #25047

fmarier opened this issue Aug 29, 2022 · 1 comment · Fixed by brave/brave-core#14875
Assignees
@deeppandya
Labels
feature/safebrowsing OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude security
Milestone
1.45.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Aug 29, 2022

A community thread has brought to my attention that we currently have a Safe Browsing setting on Android, which claims that Safe Browsing is ON, even though it's not (it's never worked in brave-core: #8705).

We should hide this setting until we fix Safe Browsing support.

Screenshot_20220829-103855 Screenshot_20220829-103917
@fmarier fmarier added security OS/Android Fixes related to Android browser functionality feature/safebrowsing labels Aug 29, 2022
@deeppandya deeppandya self-assigned this Aug 29, 2022
@deeppandya deeppandya mentioned this issue Aug 29, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 30, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 19, 2022 •
edited
Loading

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016
  • Confirmed Safe Browsing setting is hidden under Other Privacy section
Example Example
screenshot-1666216774226 screenshot-1666216816477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/safebrowsing OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude security
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Hide safe browsing option brave/brave-core
4 participants
@fmarier @deeppandya @Uni-verse @brave-builds