Download protection service (SafeBrowsing) is blocking a file from google.com

[bsclifton]

Description

Trying to download the Chrome enterprise templates and Brave gives an error and won't allow you (no matter what you try) to access the file. Only option is to Discard. Turning off Safe Browsing resolves the issue

Steps to Reproduce

1. Be in Brave
2. Have Safe Browsing enabled (under brave://settings/security)
3. Try to download https://dl.google.com/dl/edgedl/chrome/policy/policy_templates.zip
4. Download finishes

Actual result:

Download bar shows as dangerous and you can only click Discard. Clicking down chevron sends you to a help link

Expected result:

It should download and be accessible. Works in Chrome

Reproduces how often:

100%

Version/Channel Information:

• Can you reproduce this issue with the current release? YES
• Can you reproduce this issue with the beta channel? YES
• Can you reproduce this issue with the nightly channel? YES

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NO
• Does the issue resolve itself when disabling Brave Rewards? NO
• Is the issue reproducible on the latest version of Chrome? NO

[bsclifton]

Per convo with @fmarier - call to Safe Browsing may be missing metadata

[fmarier]

After investigating this, I found that this file was blocked with the following indicators:

• UI = "Blocked - Dangerous"
• DownloadCheckResults = POTENTIALLY_UNWANTED (5)
• DownloadCheckResultReason = REASON_DOWNLOAD_POTENTIALLY_UNWANTED (21)
• DownloadDangerType = DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED (8)

and I did notice that providing the URL of the download (i.e. by commenting out this
line), changed the server verdict from POTENTIALLY_UNWANTED to SAFE. This is why it has always worked fine in Chrome.

However, while the file is still the same, I can't reproduce the POTENTIALLY_UNWANTED verdict anymore and so it looks there's been a server-side change. Perhaps Google has realized that this was a false positive.

[fmarier]

Seems to be happening again.

[fmarier]

The fix is now upstream: https://chromium.googlesource.com/chromium/src/+/4c22713700868309e30a6611702a83413dba428b

[stephendonner]

The fix is now upstream: https://chromium.googlesource.com/chromium/src/+/4c22713700868309e30a6611702a83413dba428b

Do we need to file any followup issues to remove the temporary patch on our side?

[stephendonner]

Verification PASSED using

Brave | 1.58.80 Chromium: 116.0.5845.51 (Official Build) nightly (64-bit)
-- | --
Revision | 4408cc9795df260c5d5f033660ce757782b53b32
OS | Windows 10 Version 22H2 (Build 19045.3271)

Steps:

1. installed 1.58.80
2. launched Brave
3. opened brave://settings/security
4. confirmed Safe Browsing was set to Standard Protection
5. downloaded https://dl.google.com/dl/edgedl/chrome/policy/policy_templates.zip
6. clicked Save

Confirmed policy_templates.zip didn't warn/block, and was successfully downloaded, with Safe Browsing enabled

example	example	example	example

[fmarier]

Do we need to file any followup issues to remove the temporary patch on our side?

It should happen as part of a Chromium rebase since our patch won't apply anymore (already applied upstream).