Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sidebar talk button activate brave talk tab from any window #27794

Closed
simonhong opened this issue Jan 13, 2023 · 1 comment · Fixed by brave/brave-core#16704
Closed

Make sidebar talk button activate brave talk tab from any window #27794

simonhong opened this issue Jan 13, 2023 · 1 comment · Fixed by brave/brave-core#16704
Assignees
@simonhong
Labels
feature/brave-talk feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@simonhong
Copy link
Member

Description

Steps to Reproduce

  1. Launch Brave and create two browser window1 and window2
  2. Click sidebar talk item at window1
  3. Activate window2 and click sidebar talk item

Actual result:

Window2 create new tab for talk

Expected result:

window 1 is activated and talk tab becomes active tab

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@simonhong simonhong self-assigned this Jan 13, 2023
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". feature/brave-talk labels Jan 13, 2023
@simonhong simonhong mentioned this issue Jan 17, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jan 20, 2023
@simonhong
Improve tab activation for builtin sidebar shortcut items
f239738 
Try to activate a related tab from all browser windows not just from
current window. With this change, user can activate talk(or wallet) tab
from another browser window.

fix brave/brave-browser#27794
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 20, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Followed the test plan at #27794 (comment)

Confirmed clicking the Brave Talk icon in one open window (of two) doesn't spawn a third window, but focuses the Brave Talk window

window1 focused window2 focused window1 focused
Screen Shot 2023-02-08 at 12 22 56 AM Screen Shot 2023-02-08 at 12 24 06 AM Screen Shot 2023-02-08 at 12 24 37 AM

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/brave-talk feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Improve tab activation for builtin sidebar shortcut items brave/brave-core
4 participants
@stephendonner @rebron @simonhong @brave-builds