Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close windows when all non-pinned tabs are closed, with shared pinned tabs enabled #38414

Closed
Tracked by #28873
sangwoo108 opened this issue May 19, 2024 · 0 comments · Fixed by brave/brave-core#23745
Closed
Tracked by #28873

close windows when all non-pinned tabs are closed, with shared pinned tabs enabled #38414

sangwoo108 opened this issue May 19, 2024 · 0 comments · Fixed by brave/brave-core#23745
Assignees
@sangwoo108
Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.68.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented May 19, 2024 •
edited
Loading

Expected

  • When there're multiple windows
  • And all unpinned tabs are a window is closed
  • Close the window

Edge case

  • drag and drop - this case shouldn't close window
@sangwoo108 sangwoo108 mentioned this issue May 19, 2024
Closed
@sangwoo108 sangwoo108 changed the title close windows when all non-pinned tabs are closed close windows when all non-pinned tabs are closed, with shared pinned tabs enabled May 19, 2024
@sangwoo108 sangwoo108 self-assigned this May 19, 2024
@sangwoo108 sangwoo108 mentioned this issue May 20, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 20, 2024
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No feature/pinned-tabs OS/Desktop release-notes/exclude labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

Close window when all tabs are shared pinned tabs brave/brave-core
2 participants
@sangwoo108 @brave-builds