-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News]: RSS Feed Parsing Performance #29511
Comments
Instructions for testing are in @stephendonner's comment here: #29438 (comment) |
Verified
|
Brave | 1.53.74 Chromium: 114.0.5735.53 (Official Build) beta (64-bit) |
---|---|
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970} |
OS | Windows 10 Version 22H2 (Build 19045.3031) |
Steps:
- installed
1.53.74
- launched Brave
- skipped onboarding
- opened a new-tab page
- enabled Brave News
- loaded
mate-desktop.org
- waited 30 seconds
- checked
brave.exe
CPU usage
Confirmed CPU usage was very low - reaching a high of 2-3%, idling slightly lower, on average
Task Manager | process details |
---|---|
In addition, I also tested -- but didn't save/post results, here -- |
Verified on
STEPS:
ACTUAL RESULTS:
timestamp_19-48-02_19-50-08.mp4NOTE: When no apps opened, the lowest CPU usage was ~16% |
Removing |
The above requires |
Verified with
Steps:
Confirmed CPU usage was very low - reaching a high of 2-3%, idling slightly lower, on average
For comparison, these are the results when running on 1.52.122, CPU is notably higher.
|
Verification passed on
Steps:
Confirmed CPU usage was very low - reaching a high of 2%, idling slightly lower, on average |
Verified on
STEPS:
ACTUAL RESULTS:
Pixel 7 [Android 8] timestamp_16-00-40_16-02-40.mp4Galaxy Tab S8 [Android 13] timestamp_15-53-21_15-55-12.mp4Pixel 7 [Android 14] timestamp_15-28-34_15-31-16.mp4 |
This is a followup to #29438 where we limited the number of feeds which could be parsed at the same time.
Looks like the root cause of the slowdown is that
voca_rs
is looking at graphemes when they shouldn't be (resulting in some O(N^2+) algorithms). As a temporary fix, I'm looking at manually stripping the HTML tags.However, in future it would be good to do the following:
The text was updated successfully, but these errors were encountered: