Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless enable notifications dialog on Android 8 #29563

Closed
SergeyZhukovsky opened this issue Apr 6, 2023 · 3 comments · Fixed by brave/brave-core#17972
Closed

Endless enable notifications dialog on Android 8 #29563

SergeyZhukovsky opened this issue Apr 6, 2023 · 3 comments · Fixed by brave/brave-core#17972
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

It happens on stable channel as well on Android 8 device only.

  • Install Brave on Android 8 device.
  • Enable Rewards and observe a prompt to enable notifications.
  • Observe the prompt every time you open a panel even though they are enabled, there is no way to get rid of it.
notifications.webm

cc @Miyayes

@SergeyZhukovsky SergeyZhukovsky added bug feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Apr 6, 2023
@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Apr 7, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 13, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Apr 17, 2023

@Uni-verse @vlad-hoff we'll need @srirambv to check this one as he has a Android 8 device available and was originally able to reproduce the above. It will be hard to QA via emulators as Rewards doesn't work on x86. Hopefully the devices that @deeppandya sent over will get here soon so I can help out 👍 We'll also need to check to make sure the above is still working on newer versions of Android as well.

@kjozwiak
Copy link
Member

The above requires 1.50.120 or higher for 1.50.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 18, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 18, 2023

Verified on Samsung GS 21 running Android 13 using the following build(s):

Brave	1.50.120 Chromium: 112.0.5615.121 (Official Build) (64-bit) 
Revision	39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS	Android 13; Build/TP1A.220624.014

STR: #29563 (comment)

  • Ensured that enable notifications dialog is not shown in the rewards panel as well as the brave://rewards page after enabling notifications in setting menu.
  • Ensured that turn on notifications dialog is shown when loading brave://rewards
  • Ensured that turn on notifications dialog is displayed when accessing rewards panel when rewards account is connected.
  • Ensured turning off Brave notifications will show the dialog again.
Disabled (Rewards Page) Disabled (Panel) Enabled (Panel) Enabled (Rewards Page) Settings
screenshot-1681848176433 screenshot-1681848544877 screenshot-1681848247191 screenshot-1681848561710 screenshot-1681848639949

Verification passed on Huawei P20 with Android 8.1.0 running 1.50.120 x64 build

  • Verified steps from #29563 (comment)
  • Verified enable notifications are not constantly shown after enabling Rewards
  • Verified enable notifications are only shown when app notification is disabled
29563.mp4

@Uni-verse Uni-verse removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants