Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send tip button doesn't get activated when min custom tip of 0.25 BAT is entered #30909

Closed
GeetaSarvadnya opened this issue Jun 8, 2023 · 2 comments · Fixed by brave/brave-core#18841
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28149
Send tip button doesn't gets activated when min custom tip of 0.25 BAT is entered

Steps to reproduce

Case 1:

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and click on the Custom
  5. Enter the custom tip mini amount of 0.25 BAT
  6. Send tip button doesn't get activated when min custom tip of 0.25 BAT is entered

Case 2:

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and click on the Custom
  5. Enter the custom tip mini amount of 0.26 BAT
  6. Send button gets activated
  7. Click on the up and down arrow to convert the USD and BAT values
  8. The custom tip amount 0.26 BAT is rounded to 0.25 BAT as expected but the Send button is not activated
  9. Send tip button doesn't get activated when min custom tip of 0.25 BAT is entered

Actual result

Send tip button doesn't get activated when min custom tip of 0.25 BAT is entered

image

Expected result

The Send tip button should get activated when min custom tip of 0.25 BAT is entered

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@kjozwiak
Copy link
Member

The above requires 1.53.96 or higher for 1.53.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.53.99

Example Example
Screenshot_20230619_153127 Screenshot_20230619_153220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants