Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custodian mismatch message is displayed in the tipping banner for the grandfathered unconnected user in 1.53 #30935

Closed
GeetaSarvadnya opened this issue Jun 9, 2023 · 2 comments · Fixed by brave/brave-core#18871
Closed

Custodian mismatch message is displayed in the tipping banner for the grandfathered unconnected user in 1.53 #30935

GeetaSarvadnya opened this issue Jun 9, 2023 · 2 comments · Fixed by brave/brave-core#18871
Assignees
@sujitacharya2005
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 9, 2023 •
edited
Loading

Description

Found while testing #28149
Custodian mismatch message is displayed in the tipping banner for the grandfathered unconnected user in 1.53

Steps to reproduce

  1. Clean profile 1.47.119 beta build
  2. Enable rewards and claim UGP grants or Ad garnts
  3. Upgrade the profile to 1.53.x
  4. Open the laurenwags.githu.io verified creator
  5. Open the tipping banner (there is UPHOLD icon disaplyed, logged UPHOLD icon is displayed next to the Brave Rewards balance in the tipping banner for Grandfathered unconnected user in 1.53.x #30936)
  6. Confirmed that there is no mismatch custodian message on the tipping banner as expected
  7. Open github.com/miyayes verified creator
  8. Open the tipping banner
  9. Custodian mismatch message is displayed in the tipping banner
  10. Open alexvincentmusic.com verified creator
  11. Open the tipping banner
  12. Custodian mismatch message is displayed in the tipping banner

Actual result

Custodian mismatch message is displayed in the tipping banner for the grandfathered unconnected user in 1.53

Gemini bitFlyer
Screenshot_20230709_114808 Screenshot_20230709_114838
Screenshot_20230609_123410 Screenshot_20230609_123440

Expected result

custodian mismatch message should not be displayed in the tipping banner for the grandfathered unconnected user

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet):All
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005
@GeetaSarvadnya GeetaSarvadnya added feature/rewards QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels Jun 9, 2023
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 9, 2023
Closed
@sujitacharya2005 sujitacharya2005 mentioned this issue Jun 9, 2023
Merged
25 tasks
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 10, 2023
@sujitacharya2005 sujitacharya2005 mentioned this issue Jun 12, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 14, 2023
@brave-builds brave-builds mentioned this issue Jun 17, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.53.102 or higher for 1.53.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.53.102

Example Example
Screenshot_20230622-205356_Brave Screenshot_20230622-205423_Brave

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujitacharya2005 sujitacharya2005

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Custodian mismatch message brave/brave-core
5 participants
@kjozwiak @Miyayes @sujitacharya2005 @GeetaSarvadnya @brave-builds