Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pk_cid parameter #31084

Closed
fmarier opened this issue Jun 15, 2023 · 2 comments · Fixed by brave/brave-core#19144
Closed

Remove pk_cid parameter #31084

fmarier opened this issue Jun 15, 2023 · 2 comments · Fixed by brave/brave-core#19144
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Jun 15, 2023

While described as a campaign tracking ID, the official Piwik documentation says that the glcid is typically passed through in this parameter.
@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Jun 15, 2023
@fmarier fmarier self-assigned this Jun 15, 2023
@fmarier fmarier mentioned this issue Jun 15, 2023
Merged
@fmarier fmarier added the priority/P4 Planned work. We expect to get to it "soon". label Jun 15, 2023
fmarier added a commit to brave/brave-core that referenced this issue Jul 5, 2023
@fmarier
Remove Piwik/Matomo Campaign IDs from query string (fixes brave/brave…
9241149 
…-browser#31084)

These parameters are typically used to pass through
highly-identifying values (e.g. gclid).
@fmarier fmarier mentioned this issue Jul 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jul 5, 2023
@stephendonner
Copy link

Verified PASSED using

Brave | 1.58.78 Chromium: 116.0.5845.51 (Official Build) nightly (64-bit)
-- | --
Revision | ca260d83d1ffda3cb35bff4bdc3251f30f9c8ccd
OS | Windows 10 Version 22H2 (Build 19045.3271)

Followed the steps to reproduce using brave/brave-core#19144 (comment)

Confirmed both the mtm_cid and pk_cid parameters were dropped from the page load, by an internal redirect

image

@hffvld
Copy link
Contributor

hffvld commented Aug 16, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB5.230623.003 release-keys]
Brave build: 1.58.83
Chromium: 116.0.5845.62 (Official Build) beta (64-bit) 
Revision: 6790b00a844c526d81126dd437569d1b205979ec

STEPS:
Followed the steps from brave/brave-core#19144 (comment)

ACTUAL RESULTS:

  • Verified that both the mtm_cid and pk_cid parameters were dropped from the page load, by an internal redirect.
1
1

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
This was referenced Sep 15, 2023
Closed
Closed
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
@lyubomyr-shaydariv
https://github.com/brave/brave-browser/issues/31084
55593eb
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
@lyubomyr-shaydariv
https://github.com/brave/brave-browser/issues/31084
2becedd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Piwik/Matomo Campaign IDs from query string brave/brave-core
4 participants
@fmarier @stephendonner @brave-builds @hffvld