Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookalike URL popup has a broken Learn more link #31396

Closed
fmarier opened this issue Jun 30, 2023 · 3 comments · Fixed by brave/brave-core#19266
Closed

Lookalike URL popup has a broken Learn more link #31396

fmarier opened this issue Jun 30, 2023 · 3 comments · Fixed by brave/brave-core#19266

Comments

@fmarier
Copy link
Member

fmarier commented Jun 30, 2023

The popup that warns users about lookalike sites:
braze-not-brave
Screenshot (Jun 30, 2023 13_23_59)

unhelpfully links to the https://support.brave.com/ homepage.

We should create a custom support.brave.com page which links to the Chrome technical documentation so that users can understand why they're being shown these messages.

@fmarier fmarier self-assigned this Jun 30, 2023
@fmarier fmarier added the OS/Android Fixes related to Android browser functionality label Jun 30, 2023
@Brave-Matt
Copy link

Document is live here:
https://support.brave.com/hc/en-us/articles/17550072876045

@hffvld
Copy link
Contributor

hffvld commented Aug 16, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB5.230623.003 release-keys]
Brave build: 1.58.83
Chromium: 116.0.5845.62 (Official Build) beta (64-bit) 
Revision: 6790b00a844c526d81126dd437569d1b205979ec

STEPS:
Followed the steps from brave/brave-core#19266 (comment)

ACTUAL RESULTS:


1 2 3
1 2 3

@stephendonner
Copy link

Verification PASSED using

Brave | 1.58.90 Chromium: 116.0.5845.96 (Official Build) beta (x86_64)
-- | --
Revision | c112ad8c854bd34b48f4e87bfb3f7951e426a1d4
OS | macOS Version 11.7.9 (Build 20G1426)

Steps:

  1. installed 1.58.90
  2. launched Brave
  3. opened brave://components
  4. confirmed Safety Tips 2987 component
  5. clicked on Check for update
  6. confirmed it showed no updates
  7. loaded http://www.ogogle.com/
  8. confirmed Did you mean Google.com? popup
  9. clicked on Learn more

Confirmed clicking on the Learn more link took me to the appropriate Support article: https://support.brave.com/hc/en-us/articles/17550072876045-Lookalike-URLs

example example example example
Screen Shot 2023-08-16 at 10 47 04 AM Screen Shot 2023-08-16 at 10 47 10 AM Screen Shot 2023-08-16 at 10 47 18 AM Screen Shot 2023-08-16 at 10 47 28 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants