Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable Twitter web notifications after update to v0.60.55 #3464

Closed
Brave-Matt opened this issue Feb 22, 2019 · 11 comments
Closed

Cannot enable Twitter web notifications after update to v0.60.55 #3464

Brave-Matt opened this issue Feb 22, 2019 · 11 comments
Labels
closed/duplicate Issue has already been reported priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@Brave-Matt
Copy link

Description

After the update to v0.60.55 (release), Twitter web notifications no longer function in Brave. This is not strictly because they don't function - but rather because they can't be set from within your Twitter profile settings.

Steps to Reproduce

  1. Login to Twitter.com in Brave
  2. On Twitter, Profile --> Settings & Privacy --> Web Notifications
  3. Click Turn on to enable web notifications for Twitter
  4. Page prompts you to select Allow in browser modal - do so.

Actual result:

After clicking allow, the page refreshes and changes are not saved. Notifications are not enabled and the page looks as if you had just arrived there, but now the Turn on button is unresponsive.

Expected result:

Web notifications should be enabled.

Reproduces how often:

Always

Brave version/Reproducible on

Current release: Yes - v0.60.55
Dev/Beta builds: Yes - v0.62.6/v0.61.36

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

Initial user report was very detailed and well written, found here. I also attached short recording of the behavior.
https://community.brave.com/t/unable-to-turn-on-twitter-web-notifications/45690/3

twitternotis

@Brave-Matt Brave-Matt added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Feb 22, 2019
@rashbaugh3
Copy link

I did a Safeboot with Networking and only opened Brave, not Firefox. Same problem with Twitter notifications.

@bbondy
Copy link
Member

bbondy commented Mar 5, 2019

@Brave-Matt is this still an issue?

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 5, 2019
@Brave-Matt
Copy link
Author

@bbondy @rebron
Just tested on v0.61.51 and it is still an issue - in fact, the option to click the "web notifications" button is no longer present and now displays the following message:
image

@siffreinsg
Copy link

Still an issue in the new Twitter UI. It will ask for permission, however the "switch" (see screen) stays off and the animation seems broken.
image

@jonathansampson
Copy link
Contributor

Worth noting that this issue exists even when the Brave and Rewards extensions are disabled:

> brave.com --disable-brave-extension --disable-brave-rewards-extension

@bsclifton
Copy link
Member

Likely a duplicate of #2301

I'm curious if Twitter is trying to push a message and making sure you acknowledge it before enabling (or browser would prompt you first time, "allow notifications from x?")

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 27, 2019

+1 User mentions that this has caused them to revert back to Chrome. https://www.reddit.com/r/BATProject/comments/dnay4q/when_will_the_twitter_notifications_bug_be_fixed/f59b6mk/?context=3

@Brave-Matt
Copy link
Author

Brave-Matt commented Dec 6, 2019

@thommesborg
Copy link

Still an issue, yes. When I click on "enable push notifications" I'll get informed that my browser won't support push-notifications.

Here's a screenie of the result:
Bildschirmfoto 2019-12-16 um 07 39 23

@rashbaugh3
Copy link

Issue not resolved as a side effect of other updates. Gonna need specific attention.

@bsclifton
Copy link
Member

Closing as a duplicate of #2362

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

8 participants