Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Swipe causes Rewards and Shields button area to retain previous tabs theme #37342

Closed
srirambv opened this issue Apr 4, 2024 · 4 comments · Fixed by brave/brave-core#23271
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2024

Description

Tab Swipe causes Rewards and Shields button area to retain previous tabs theme

Steps to reproduce

  1. Visit multiple pages which have dark and light theme
  2. Swipe to switch tabs via URL bar
  3. Rewards and Shields button area retains the previous tabs theme

Actual result

Swipe.View.mp4

Expected result

Theme should be applied to all URL bar elements

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 14/13

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @hffvld @Uni-verse @samartnik

@hffvld
Copy link
Contributor

hffvld commented Apr 4, 2024

It looks like a similar issue #36438 was fixed and verified, but I could reproduce this issue from above as well when the device theme is set to Light Mode.


2024-04-04_10-41-31.mp4

@samartnik
Copy link
Contributor

samartnik commented Apr 24, 2024

Issue comes from the upstream, the same issue is with Chrome

screen-20240422-165746.mp4

@samartnik
Copy link
Contributor

As a solution we now postpone transition animation until swipe finishes
Screen_recording_20240424_100644.webm

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo x70 Pro version 12 running Bravemonoarm64.apk_1.67.90

Recorder_30052024_170702.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants