Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag shields settings on to page shows up about:blank #417

Closed
srirambv opened this issue Jun 24, 2018 · 1 comment · Fixed by brave/brave-extension#51
Closed

Drag shields settings on to page shows up about:blank #417

srirambv opened this issue Jun 24, 2018 · 1 comment · Fixed by brave/brave-extension#51

Comments

@srirambv
Copy link
Contributor

Description

Drag shields settings on to page shows up abut:blank

Steps to Reproduce

  1. Open release build
  2. Visit any page
  3. Click on shields, drag Edit default shield settings... and drop on page, tab opens up about:blank

Actual result:

shieldsdrag
Console logs the following error

Unable to read VR Path Registry from C:\Users\\AppData\Local\openvr\openvrpaths.vrpath
[13816:11640:0624/190629.034:ERROR:CONSOLE(24)] "Uncaught Error: Assertion failed", source: chrome://settings/crisper.js (24)

Expected result:

Dnd of shields settings should not cause any page reload.

Reproduces how often:

100%

Brave version (about:brave info)

80614db

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. labels Jun 24, 2018
@srirambv srirambv added this to the Releasable builds milestone Jun 24, 2018
@bbondy bbondy changed the title Drag shields settings on to page shows up abut:blank Drag shields settings on to page shows up about:blank Jun 27, 2018
@bbondy bbondy modified the milestones: Releasable builds, Backlog Jun 27, 2018
@cezaraugusto cezaraugusto self-assigned this Jul 4, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 24, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 24, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 30, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Edit default shield settings... is no longer draggable.

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified Edit default shield settings... can no longer be dragged

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Verified Edit default shield settings... can no longer be dragged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants