Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit shields settings and Reload buttons in shields doesn't work #561

Closed
srirambv opened this issue Jul 16, 2018 · 1 comment · Fixed by brave/brave-extension#51
Closed

Edit shields settings and Reload buttons in shields doesn't work #561

srirambv opened this issue Jul 16, 2018 · 1 comment · Fixed by brave/brave-extension#51
Assignees
@cezaraugusto
Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Edit shields settings and Reload buttons in shield doesn't work

Steps to Reproduce

  1. Open a new tab and visit any site
  2. Open shields
  3. Edit shields/Reload buttons doesn't work

Actual result:

Edit shields settings and Reload buttons in shield doesn't work

Expected result:

Should work similar to b-l

Reproduces how often:

100%
@srirambv srirambv added this to the Releasable builds milestone Jul 16, 2018
@cezaraugusto cezaraugusto self-assigned this Jul 17, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 24, 2018
@cezaraugusto
support open settings and reload actions
1f2b3e2 
-
closes brave/brave-browser#561
closes brave/brave-browser#417
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 24, 2018
@cezaraugusto
support open settings and reload actions
6bed473 
-
closes brave/brave-browser#561
closes brave/brave-browser#417
@cezaraugusto cezaraugusto mentioned this issue Jul 24, 2018
Merged
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2018 •
edited by LaurenWags
Loading

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified Edit shields settings load Global settings page but should open shields setting to be fixed with Global shields settings  #348
  • Verified Reload reloads the current page

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • Verified Edit shields settings load Global settings page but should open shields setting to be fixed with Global shields settings  #348
  • Verified Reload reloads the current page

@rebron rebron mentioned this issue May 28, 2020
Closed
This was referenced May 28, 2020
Closed
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue May 29, 2020
Closed
@rebron rebron mentioned this issue May 29, 2020
Closed
This was referenced Jun 5, 2020
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jun 8, 2020
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 8, 2020
Closed
This was referenced Jun 8, 2020
Closed
Closed
This was referenced Jun 8, 2020
Closed
Closed
@btlechowski btlechowski mentioned this issue Jun 9, 2020
Closed
This was referenced Jun 9, 2020
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 10, 2020
Closed
@btlechowski btlechowski mentioned this issue Jun 10, 2020
Open
@kjozwiak kjozwiak mentioned this issue Jun 10, 2020
Closed
@btlechowski btlechowski mentioned this issue Jun 10, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 10, 2020
Closed
This was referenced Jun 10, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

support open settings and reload actions brave/brave-extension
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya