Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter tips button needs proper spacing #6456

Closed
rebron opened this issue Oct 12, 2019 · 8 comments · Fixed by brave/brave-core#3817
Closed

Twitter tips button needs proper spacing #6456

rebron opened this issue Oct 12, 2019 · 8 comments · Fixed by brave/brave-core#3817

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 12, 2019

Description

Twitter Tips button is too close to the share button and needs proper spacing/padding.

Actual result:

Screen Shot 2019-10-11 at 11 52 47 PM

Expected result:

61867921-e8f37280-aef5-11e9-8e2c-79c5ce4c9a37

See: #4548

Reproduces how often:

This reproduces easily in 0.69.135.

  1. Login to Twitter
  2. Ensure Brave Rewards is on.
  3. Notice Twitter Tips button placement.

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@alexandriaroberts
Copy link

Hey @rebron I can do it!! 👍

@kjozwiak
Copy link
Member

Looks like this is also reproducible using 0.67.123 CR: 76.0.3809.87 which means Twitter must have changed something in their end which is causing the problem. Seems to be happening when you're logged into Twitter.

Example while being logged in:

Screen Shot 2019-10-12 at 11 43 12 AM

Example while being logged out:

Screen Shot 2019-10-12 at 11 43 43 AM

@brimwats1
Copy link

It would be excellent if the twitter tip button could be turned on and off. I'm happy to try out BAT, but I cannot stand the button so I had to opt out of BAT.

@srirambv
Copy link
Contributor

Possible dupe of #4562

@bsclifton
Copy link
Member

@brimwats you actually can turn it off on a per-publisher basis:

  1. Navigate to brave://rewards/
  2. Click the Tip Settings button
    Screen Shot 2019-10-13 at 10 38 40 PM
  3. Uncheck the types that you don't want to see (or uncheck them all!)
    Screen Shot 2019-10-13 at 10 39 51 PM

@bsclifton
Copy link
Member

@alexandriaroberts you're definitely welcome to grab this! 😄 I've been putting together a contributor guide (not merged yet) which has some tips for getting started:
#6265
(comments extremely welcomed!)

Once you get setup and have things building, editing the rewards parts shouldn't be too hard
cc: @ryanml

@alexandriaroberts
Copy link

Hey @bsclifton , Yes, I would love too!! Thank you! I will set my laptop up and will start working on it. Thank you.😀 If I have any questions I will message here! 😊

@mandar-brave mandar-brave added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Oct 14, 2019
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. 1.0 and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Oct 15, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 30, 2019
@rebron rebron added this to the 0.73.x - Nightly milestone Oct 31, 2019
@ryanml ryanml modified the milestones: 0.73.x - Nightly, 0.71.x - Beta Nov 1, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019

Verification passed on

Brave 0.71.108 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    image
    image

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
    image
    image

Verified passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
  • Verified tip button appears spaced correctly for tweets in my feed:

Screen Shot 2019-11-04 at 3 48 37 PM

  • Verified tip button appears spaced correctly for my own tweets (when logged in):

Screen Shot 2019-11-04 at 3 49 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.