Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NTP Brave Stats to 'Trackers & Ads Blocked' on desktop #9692

Closed
karenkliu opened this issue May 8, 2020 · 2 comments · Fixed by brave/brave-core#5630
Closed

Update NTP Brave Stats to 'Trackers & Ads Blocked' on desktop #9692

karenkliu opened this issue May 8, 2020 · 2 comments · Fixed by brave/brave-core#5630

Comments

@karenkliu
Copy link

karenkliu commented May 8, 2020

Description

Update NTP Brave Stat text from 'Ads and Trackers Blocked' to 'Trackers & ads blocked'

Actual result:

Screen Shot 2020-05-08 at 11 16 52 AM

Expected result:

Screen Shot 2020-05-08 at 11 18 29 AM

Reproduces how often:

Easily

Brave version (brave://version info)

All builds

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous

This update is expected on all platforms.
iOS brave/brave-ios#2528
Android #9693

@karenkliu karenkliu changed the title Update NTP Brave Stats to 'Trackers & Ads Blocked' Update NTP Brave Stats to 'Trackers & Ads Blocked' on desktop May 8, 2020
@rebron rebron added needs-text-change This change requires some careful wording. QA/Yes feature/new-tab labels May 29, 2020
@rebron
Copy link
Collaborator

rebron commented May 29, 2020

@0xedward Nice.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 8, 2020

Verification passed on

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description
  • Verified both clean and upgraded profile
  • Trackers & ads blocked count is retained after browser restart
    image
    image

Verification PASSED on macOS 10.15.5 x64 Catalina using the following build:

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.15.5 (Build 19F101)
  • ensured that Ads and Trackers Blocked was renamed to Trackers & ads blocked under NTP
  • ensured that stats under NTP are being updated when visiting websites
  • ensured that restarting the browser doesn't reset the NTP stats
  • ensured that disabling/enabling stats on NTP works without any issues
  • ensured upgrading from 1.9.76 --> 1.10.86 didn't cause any issues

Screen Shot 2020-06-08 at 11 09 24 AM


Verification passed on

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS
  • ensured that Ads and Trackers Blocked was renamed to Trackers & ads blocked under NTP
  • ensured that stats under NTP are being updated when visiting websites
  • ensured that restarting the browser doesn't reset the NTP stats
  • ensured that disabling/enabling stats on NTP works without any issues
  • ensured upgrading from 1.9.76 --> 1.10.86 didn't cause any issues
  • encountered [Desktop] NTP stats strings are not translated #9990

image
Polish
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment