Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Buy/Swap UI for Unsupported Networks #10055

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

  1. Added Logic to bump you to the Send tab if you select an unsupported network.
  2. Disabled the Buy/Swap tabs after selecting an unsupported network.
  3. Build a custom tooltip for Buy/Send/Swap buttons to display Network not Supported on hover.

Resolves brave/brave-browser#18004

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-09-10.at.5.07.08.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Sep 11, 2021
@Douglashdaniel Douglashdaniel force-pushed the disabled-buy-swap-for-unsupported-network branch 3 times, most recently from 5b2bd3b to b56a057 Compare September 13, 2021 15:28
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For swap, only mainnet and ropsten are supported. If you can include that in this PR it'd be great, otherwise, I'll do it on my side.

@Douglashdaniel Douglashdaniel force-pushed the disabled-buy-swap-for-unsupported-network branch 2 times, most recently from dfbba56 to 4ed9e69 Compare September 14, 2021 19:14
@Douglashdaniel Douglashdaniel force-pushed the disabled-buy-swap-for-unsupported-network branch from 4ed9e69 to 7902e72 Compare September 14, 2021 19:56
@Douglashdaniel
Copy link
Contributor Author

For swap, only mainnet and ropsten are supported. If you can include that in this PR it'd be great, otherwise, I'll do it on my side.

Updated! Thank you!

@Douglashdaniel Douglashdaniel merged commit 590afe2 into master Sep 15, 2021
@Douglashdaniel Douglashdaniel deleted the disabled-buy-swap-for-unsupported-network branch September 15, 2021 02:10
@Douglashdaniel Douglashdaniel added this to the 1.31.x - Nightly milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable buy/swap UI when on unsupported network.
2 participants