-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes widget to return to the double stacked stats and top sites view for NTP #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsafe
added
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
labels
Mar 24, 2022
alexsafe
force-pushed
the
remove-widgets-part1
branch
from
March 25, 2022 14:24
bb55525
to
7515c4d
Compare
alexsafe
requested review from
deeppandya,
AlexeyBarabash,
SergeyZhukovsky and
tapanmodh
March 25, 2022 14:26
[Android] Removes NTP widget dependencies
alexsafe
force-pushed
the
remove-widgets-part1
branch
from
March 25, 2022 14:36
7515c4d
to
5791e65
Compare
SergeyZhukovsky
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++. Nice clean up!
AlexeyBarabash
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
brave-builds
pushed a commit
that referenced
this pull request
Mar 29, 2022
7 tasks
7 tasks
This was referenced Mar 29, 2022
deeppandya
pushed a commit
that referenced
this pull request
Apr 21, 2022
Verification PASSED on
|
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#21826
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: